refactor(core): introduce Simplified trait #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to abstract over some common operations between models [no changelog]
|
|
|
I like the trait idea, but i think this doesn't go far enough for my needs. I have expanded this concept in #3658 , see if it makes sense to you. |
|
overall yes. but let's resolve that in your PR and merge this one (unless you see something wrong), so that we get the fix for the T2B1 unit tests |
TychoVrahe
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to abstract over some common operations between models.
This also fixes test failure on T2B1 caused by incorrect import symbols.
related to #3608