introduce UIFeatures trait #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TychoVrahe
force-pushed
the
tychovrahe/simplified_trait/refactor
branch
from
3cecd67
to
0524a35
Compare
|
mmilata
reviewed
Apr 4, 2024
matejcik
reviewed
Apr 4, 2024
Merged
matejcik
approved these changes
Apr 5, 2024
TychoVrahe
force-pushed
the
tychovrahe/simplified_trait/refactor
branch
from
6625666
to
37ff46a
Compare
…over different UI implementation [no changelog]
TychoVrahe
force-pushed
the
tychovrahe/simplified_trait/refactor
branch
from
37ff46a
to
a742a24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an abstraction over different UI implementations
Two UI traits are introduced:
UIFeaturesBootloaderUIFeaturesCommonUIFeaturesFirmwarewould be next step.API files are introduced too, defining an unified interface between C and rust in
ui/api/bootloader_c.rsandui/api/common_c.rs. Purpose is to make all necessary type conversions here, so that specific UI implementations for different models get already pure rust arguments, and the type conversions are same for all UIs.