Unicode font uppercasing issues #3696

obrusvit · 2024-04-09T20:10:50Z

some_text.upper() calls do not work correctly in languages other than english. This PR adds additional Fonts which are UPPERCASE only. These fonts are used where appropriate, especially in Titles and Buttons.

For Model T, this meant only switching FONT_BOLD to FONT_BOLD_UPPER
For Model R, this meant adding additional fonts FONT_NORMAL_UPPER and FONT_BOLD_UPPER and use them where appropriate
For both models: some diffs emerged, listed below.

TODO:

Hannsek · 2024-04-10T08:02:29Z

All summary screens use that. Can it be changed back?

obrusvit · 2024-04-15T09:44:08Z

Status (updated 2024/04/28)
Model T:

FIX: changing translation

Model R:

FIX: PIN setting - the 2nd screen didn't have title and scrollbar. Moreover, if you went to 2nd screen and then back, the title was gone:

and another case:
FIX: similar thing in Wipe code setting:
FIX: altcoin summary had title wrongly placed
FIX: changing translations
CHANGE from bold to normal in confirm message.
CHANGE from lowercase to uppercase: all warnings are now with uppercased letter, some were not before. I believe these changes have no effect on the user. Full list:
- receiving to multisig address
- locktime has no effect
- sending from multiple accounts
- unusually high fee
- many change outputs
- unverified external inputs
- group threshold reached
- invalid seed/share entered
- share already entered
- share from different backup entered
- wrong word selected (backup check)
- PINs do not match
- invalid PIN
- wrong PIN
- cardano - unknwon colateral
- solana - unknown instructions
  Examples:
CHANGE from uppercase to lowercase in "Please wait" screen
BUG: ETH Claim transaction is now lowercased on the 2nd screen

github-actions · 2024-04-28T19:34:57Z

legacy UI changes	device test(screens) main(screens)

github-actions · 2024-04-28T19:35:02Z

core UI changes	device test	click test	persistence test
T2T1 Model T	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
T2B1 Safe 3	3280	test(screens) main(screens)	2724
T3T1	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
All	main(screens)

core/embed/lib/fonts/font_tthoves_bold_upper_17.c

core/SConscript.firmware

core/SConscript.bootloader

obrusvit · 2024-05-08T09:56:15Z

A lot of diff in fixtures due to many minor changes in languages as described in the previous comment.

Also some previous changes were not incorporated into fixtures from #3617

Some UI fixtures were missing for TS3, e.g. some tests of wipe code.

mmilata

A few things but otherwise looking very good. T3T1 fixtures are missing.

mmilata · 2024-05-08T13:29:45Z

core/translations/cs.json

    },
    "T2T1": {
      "1_FONT_NORMAL": "font_tthoves_regular_21_cs.json",
-      "2_FONT_BOLD": "font_tthoves_bold_17_cs.json",
+      "2_FONT_BOLD": null,


I wonder if we should swap 2<->7 for the scenario where newer translation blob is used on old firmware that expects existing font under id 2. (edit: but that would break compatibility on T2B1, never mind)

core/tools/codegen/gen_font.py

core/embed/rust/src/ui/model_tt/theme/mod.rs

obrusvit · 2024-05-08T16:10:09Z

T3T1 fixtures also updated @mmilata f53f8ab

mmilata

LGTM, feel free to rebase and merge if CI passes.

The new option allows generation of font glyph definition where both lowercase and uppercase letters are mapped to uppercase glyphs. [no changelog]

[no changelog]

By default, buttons have uppercased font. The addition is necessary to customize font on info buttons where we need normal font. [no changelog]

[no changelog]

The title previously disappeared after going back and forth. Used in PIN setting and FIDO confirm. [no changelog]

[no changelog]

The change is necessary for future models where titles might not be uppercased. [no changelog]

Updating after UTF-8 uppercasing issue. Only changes for Model T are during language change where it actually fixes a problem. Model R has more changes - especially in show_warning invocation. See PR 3696 for more info. [no changelog]

Probably an omission after pull #3710. Update using ../tests/update_fixtures.py local -r [no changelog]

This commit changes translations strings of ES, FR, CS, DE langs so that they do not use UPPERCASED titles, button labels and other texts. [no changelog]

[no changelog]

bosomt · 2024-07-01T13:56:38Z

QA OK

tested on Czech translation

Device: Trezor T2T1 2.7.2 regular (revision da75d8f)

obrusvit added core Trezor Core firmware. Runs on Trezor Model T and T2B1. T3T1 Trezor Safe 5 translations Put this label on a PR to run tests in all languages labels Apr 9, 2024

obrusvit self-assigned this Apr 9, 2024

obrusvit linked an issue Apr 9, 2024 that may be closed by this pull request

Unicode font uppercasing issues #3600

Closed

obrusvit force-pushed the obrusvit/3600-unicode-font-uppercasing-issues branch from 39ac763 to 2bb40cd Compare April 17, 2024 10:39

obrusvit force-pushed the obrusvit/3600-unicode-font-uppercasing-issues branch from 2bb40cd to 754b701 Compare April 28, 2024 19:34

obrusvit force-pushed the obrusvit/3600-unicode-font-uppercasing-issues branch from 754b701 to b9075a1 Compare April 28, 2024 19:52

obrusvit added T2B1 Trezor Safe 3 (F4) T2T1 Trezor Model T labels Apr 28, 2024

obrusvit force-pushed the obrusvit/3600-unicode-font-uppercasing-issues branch from b9075a1 to 19a9533 Compare April 28, 2024 21:00

obrusvit marked this pull request as ready for review April 28, 2024 21:01

obrusvit requested review from matejcik and prusnak as code owners April 28, 2024 21:01

obrusvit requested review from mmilata and removed request for prusnak April 28, 2024 21:01

mmilata reviewed Apr 29, 2024

View reviewed changes

core/embed/lib/fonts/font_tthoves_bold_upper_17.c Outdated Show resolved Hide resolved

mmilata reviewed Apr 29, 2024

View reviewed changes

core/SConscript.firmware Outdated Show resolved Hide resolved

core/SConscript.bootloader Outdated Show resolved Hide resolved

obrusvit force-pushed the obrusvit/3600-unicode-font-uppercasing-issues branch 2 times, most recently from acbfe3d to 435babe Compare May 6, 2024 18:12

obrusvit mentioned this pull request May 7, 2024

fix(tests): regenerate fixtures.json #3790

Merged

obrusvit force-pushed the obrusvit/3600-unicode-font-uppercasing-issues branch 2 times, most recently from d647341 to 9e239d8 Compare May 7, 2024 22:43

obrusvit requested a review from mmilata May 8, 2024 09:52

obrusvit mentioned this pull request May 8, 2024

chore(core) rename Shamir to Multi-share #3803

Merged

mmilata requested changes May 8, 2024

View reviewed changes

mmilata approved these changes May 8, 2024

View reviewed changes

obrusvit added 13 commits May 8, 2024 18:27

refactor(tools): add gen_upper arg to gen_font

c088b26

The new option allows generation of font glyph definition where both lowercase and uppercase letters are mapped to uppercase glyphs. [no changelog]

refactor(core): apply uppercased fonts in build

00b8c36

[no changelog]

refactor(core): replace upper calls by upper font

4b12e2f

[no changelog]

refactor(core): allow changing button font on R

e70afee

By default, buttons have uppercased font. The addition is necessary to customize font on info buttons where we need normal font. [no changelog]

fix(core/ui): fix model R altcoin summary

8971836

[no changelog]

fix(core/ui): fix model R common title

fc1e806

The title previously disappeared after going back and forth. Used in PIN setting and FIDO confirm. [no changelog]

fix(tests): button content comparison

25081c5

[no changelog]

refactor(core): do not use all-caps in en.json

537affa

The change is necessary for future models where titles might not be uppercased. [no changelog]

refactor(core): update EN fixtures

768d48c

Updating after UTF-8 uppercasing issue. Only changes for Model T are during language change where it actually fixes a problem. Model R has more changes - especially in show_warning invocation. See PR 3696 for more info. [no changelog]

fix(tests): update fixtures of T2B1

9d937e9

Probably an omission after pull #3710. Update using ../tests/update_fixtures.py local -r [no changelog]

refactor(core): no all-caps in other langs jsons

cceca7c

This commit changes translations strings of ES, FR, CS, DE langs so that they do not use UPPERCASED titles, button labels and other texts. [no changelog]

refactor(core): update other langs fixtures

1ae2b4f

[no changelog]

refactor(core): update T3T1 fixtures

cf5ac3f

[no changelog]

obrusvit force-pushed the obrusvit/3600-unicode-font-uppercasing-issues branch from f53f8ab to cf5ac3f Compare May 8, 2024 16:30

obrusvit merged commit 30b50c6 into main May 8, 2024
107 of 109 checks passed

obrusvit deleted the obrusvit/3600-unicode-font-uppercasing-issues branch May 8, 2024 20:46

obrusvit mentioned this pull request May 21, 2024

Change all strings coming from storage (or somewhere else) to lowercase #3833

Closed

obrusvit mentioned this pull request Jul 23, 2024

core/translations: add 🇮🇹 🇵🇹 #4047

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unicode font uppercasing issues #3696

Unicode font uppercasing issues #3696

obrusvit commented Apr 9, 2024 •

edited

Loading

Hannsek commented Apr 10, 2024

obrusvit commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 28, 2024 •

edited

Loading

github-actions bot commented Apr 28, 2024 •

edited

Loading

obrusvit commented May 8, 2024

mmilata left a comment

mmilata May 8, 2024

obrusvit commented May 8, 2024

mmilata left a comment

bosomt commented Jul 1, 2024

Unicode font uppercasing issues #3696

Unicode font uppercasing issues #3696

Conversation

obrusvit commented Apr 9, 2024 • edited Loading

Hannsek commented Apr 10, 2024

obrusvit commented Apr 15, 2024 • edited Loading

github-actions bot commented Apr 28, 2024 • edited Loading

github-actions bot commented Apr 28, 2024 • edited Loading

obrusvit commented May 8, 2024

mmilata left a comment

Choose a reason for hiding this comment

mmilata May 8, 2024

Choose a reason for hiding this comment

obrusvit commented May 8, 2024

mmilata left a comment

Choose a reason for hiding this comment

bosomt commented Jul 1, 2024

obrusvit commented Apr 9, 2024 •

edited

Loading

obrusvit commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 28, 2024 •

edited

Loading

github-actions bot commented Apr 28, 2024 •

edited

Loading