-
-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/translations: add 🇮🇹 🇵🇹 #4047
Conversation
|
|
7f42b6c
to
c2e8e61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some problems:
- the new lang JSONs contain UPPERCASED titles and buttons (remnant from
TR
,TT
. Now they are uppercased automatically by the used font as of Unicode font uppercasing issues #3696 - some changes which occurred recently are not yet reflected, e.g.
reset__slip39_checklist_num_shares_x_template
is missing in the new JSONs it
device test still failing
I guess we can merge even with these limitations so that someone can start testing it. WDYT @mmilata
Since we're not in a rush wrt blob signing I'd say let's fix these issues & then merge. If QA or anybody wants unsigned blobs then please let me know. |
18be7b9
to
55683f1
Compare
Do you know why it device tests are failing? Is there a reason for it? |
https://github.com/trezor/trezor-firmware/actions/runs/10066871496/job/27829340045 |
I was reffering to |
Got it in a state where only (it,pt,tr) T2B1 click tests are failing. There is some issue with how the test code handles translated strings. Possibly related: if |
b42b854
to
3ca45d9
Compare
d32850b
to
8c568d8
Compare
LGTM as far as this PR is concerned. Whether the translations are good, complete, etc, is outside the scope of this. We will probably need some way to at least dump keys that are missing in various translations, but more generally to ease keeping translations in sync. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a mechanism to detect if a char is missing (as part of the tests?). For example, you did not include some chars that are technically allowed in some languages, and I understand that it is an optimization, but that also means that if something containing an "È" suddenly appears in Italian, for example, we will probably not notice it, and it will render as a "?"...
Thanks for the review!
Agreed, opened #4149. |
ea7a35e
to
91bd994
Compare
Partially added TR.
91bd994
to
eab2e18
Compare
QA OK Info:
|
Turkish translation fails click tests and from UI reports it seems there are also some missing glyphs. PR adds this third language in the current state but does not enable tests for it.