Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/ui): T3T1: wrong XPUB title #3911

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix(core/ui): T3T1: wrong XPUB title #3911

merged 2 commits into from
Jun 6, 2024

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jun 6, 2024

Fixes firmware part of trezor/trezor-suite#12775 - I believe the different line breaks are probably a Suite issue.

Screenshot 2024-06-06 at 14-51-46 T3T1_en-device_tests-cardano-test_address_public_key py test_cardano_get_public_key parameters2-result2
Screenshot 2024-06-06 at 14-51-33 T3T1_en-device_tests-bitcoin-test_getpublickey py test_get_public_node_show Bitcoin-76067358-path0-xpub6BiVtCpG-d791cce2

@mmilata mmilata added core Trezor Core firmware. Runs on Trezor Model T and T2B1. T3T1 Trezor Safe 5 translations Put this label on a PR to run tests in all languages labels Jun 6, 2024
@mmilata mmilata self-assigned this Jun 6, 2024
@mmilata mmilata requested review from matejcik and prusnak as code owners June 6, 2024 12:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@mmilata mmilata force-pushed the mmilata/ui-t3t1-xpub-title branch from 5a8661e to 577ca3b Compare June 6, 2024 13:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

legacy UI changes device test(screens) main(screens)

@mmilata mmilata merged commit 6ff7322 into main Jun 6, 2024
119 of 120 checks passed
@mmilata mmilata deleted the mmilata/ui-t3t1-xpub-title branch June 6, 2024 14:43
@mmilata
Copy link
Member Author

mmilata commented Jun 6, 2024

do we want to cherry-pick 573a2d8 to release/24.06? @matejcik @Hannsek

@Hannsek
Copy link
Contributor

Hannsek commented Jun 6, 2024

No need for that. Let's put it into the next release.

@bosomt
Copy link

bosomt commented Jun 9, 2024

QA OK

Info:

  • Suite version: desktop 24.6.1 (ee1bf19e747daba31bec272b64d09bfa8c6a807e)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.6.1 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.7.2 regular (revision e90cf36)
  • Transport: BridgeTransport 2.0.33

@bosomt
Copy link

bosomt commented Jun 14, 2024

Follow up created
#3947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik matejcik approved these changes

@prusnak prusnak Awaiting requested review from prusnak prusnak is a code owner

Assignees

@mmilata mmilata

Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. T3T1 Trezor Safe 5 translations Put this label on a PR to run tests in all languages
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmilata @Hannsek @bosomt @matejcik