Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XPUB match check does not match device and modal and its identified as receive address in modal #12775

Closed
bosomt opened this issue Jun 6, 2024 · 5 comments · Fixed by #12780
Assignees
Labels
bug Something isn't working as expected

Comments

@bosomt
Copy link
Contributor

bosomt commented Jun 6, 2024

Describe the bug
XPUB match check does not match device and modal and its identified as receive address in modal

Steps to reproduce:

  1. Navigate to Account/Detail/Public key (XPUB)
  2. Display xpub
  3. Compare modal and device

Info:

  • Suite version: desktop 24.6.1 (ee1bf19)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.6.1 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.7.1 bitcoin-only (revision 83d1ce2b8e6e4eefe09539f06b28709c8a7a89dc)
  • Transport: BridgeTransport 2.0.33

Screenshots:

@bosomt
Copy link
Contributor Author

bosomt commented Jun 6, 2024

works as expcted with TS3

  • Device: Trezor T2B1 2.7.1 bitcoin-only (revision 83d1ce2b8e6e4eefe09539f06b28709c8a7a89dc)

@bosomt bosomt transferred this issue from trezor/trezor-suite Jun 6, 2024
@Hannsek Hannsek added the bug Something isn't working as expected label Jun 6, 2024
@komret
Copy link
Contributor

komret commented Jun 6, 2024

@bosomt The layout mismatch must be resolved in Suite, can you move the issue there please?

@github-project-automation github-project-automation bot moved this to 🎯 To do in Issues Suite Jun 6, 2024
@bosomt bosomt transferred this issue from trezor/trezor-firmware Jun 6, 2024
@peter-sanderson peter-sanderson self-assigned this Jun 7, 2024
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Issues Suite Jun 7, 2024
@bosomt
Copy link
Contributor Author

bosomt commented Jun 13, 2024

QA NOK

current state, you confirm xpub on device and in suite but last "success" screen says Receive address
not sure if this is issue in Suite or in fw @komret

image

Info:

  • Suite version: desktop 24.6.1 (9d8fc58)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.6.1 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.7.2 regular (revision da75d8f4b67410b40a9cfd2954d183d81dd6e8e8)
  • Transport: BridgeTransport 2.0.33

@Hannsek
Copy link
Contributor

Hannsek commented Jun 13, 2024

This is on FW. Please create a new issue in FW repo. 🙏🏻

@bosomt
Copy link
Contributor Author

bosomt commented Jun 13, 2024

QA OK

follow up issue for fw created

Info:

  • Suite version: desktop 24.6.1 (9d8fc58)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.6.1 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device:
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants