Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T3T1 - additional wallet backup info #3954

Merged
merged 5 commits into from
Jun 30, 2024
Merged

T3T1 - additional wallet backup info #3954

merged 5 commits into from
Jun 30, 2024

Conversation

obrusvit
Copy link
Contributor

@obrusvit obrusvit commented Jun 14, 2024 •
edited
Loading

This PR adds:

  • info about repeated words in WalletCreation flow,
  • ability to display page counter information in Footer, e.g. "1 / 20".
  • alternative styles for numerals of TT Satoshi font
  • translations update

TODO:

  • update new strings in other langs
  • center the whole PageCounter content (not just around the foreslash)

@obrusvit obrusvit added the T3T1 Trezor Safe 5 label Jun 14, 2024
@obrusvit obrusvit self-assigned this Jun 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@obrusvit obrusvit linked an issue Jun 16, 2024 that may be closed by this pull request
missing formatting of a counter ("1 / 20") in Footer description in on wallet backup words #3917
Closed
@obrusvit obrusvit force-pushed the obrusvit/ui-t3t1-wallet-backup-info branch from e9f8577 to e29a988 Compare June 18, 2024 09:33
@obrusvit obrusvit marked this pull request as ready for review June 18, 2024 09:34
@obrusvit obrusvit requested review from mmilata and removed request for prusnak and matejcik June 18, 2024 09:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

mmilata
mmilata reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was hoping that we could implement a variant of Frame that holds any content which can provide current page via some (new) trait. But I suppose it's not as straightforward and am OK with the current approach. Bonus points for unit test.

core/embed/rust/src/ui/model_mercury/component/footer.rs Outdated Show resolved Hide resolved
core/embed/rust/src/ui/model_mercury/component/share_words.rs Outdated Show resolved Hide resolved
core/embed/rust/src/ui/model_mercury/component/share_words.rs Outdated Show resolved Hide resolved
core/embed/rust/src/ui/model_mercury/component/share_words.rs Show resolved Hide resolved
@obrusvit obrusvit mentioned this pull request Jun 21, 2024
Open
@obrusvit obrusvit linked an issue Jun 24, 2024 that may be closed by this pull request
T3T1 numerals should use alternative style #3747
Closed
@obrusvit obrusvit mentioned this pull request Jun 24, 2024
Closed
2 tasks
mmilata
mmilata approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rebase & merge when CI passes

@obrusvit obrusvit force-pushed the obrusvit/ui-t3t1-wallet-backup-info branch 2 times, most recently from c66a73b to a3e3c0f Compare June 24, 2024 13:12
@matejcik matejcik added this to the June release milestone Jun 25, 2024
@Hannsek Hannsek linked an issue Jun 25, 2024 that may be closed by this pull request
walletCreation/Backup flow changes #3880
Closed
2 tasks
obrusvit added 3 commits June 27, 2024 16:57
@obrusvit
feat(core/ui): highlight repeated words on T3T1
0264a92 
ShowShareWords flow now informs the user if the word is repeated. The
most typical usecase in 1-of-1 shamir (SingleShare) where 3rd and 4th
word is "academic".
@obrusvit
feat(core/ui): add PageCounter to T3T1 Footer
af04deb 
PageCounter sub-component is used within Footer to indicate progress in
screens, rendered e.g. as "1 / 20" for the first word in wallet backup.
@obrusvit
feat: use alternative numeral glyphs for T3T1
e5a7143 
Numeral chars 0-9 mapped to glyphs indices 1298-1307.
This commit does not modify gen_font.py, see issue for that.
@obrusvit obrusvit force-pushed the obrusvit/ui-t3t1-wallet-backup-info branch from a3e3c0f to eba3805 Compare June 27, 2024 14:59
@obrusvit obrusvit added the translations Put this label on a PR to run tests in all languages label Jun 27, 2024
obrusvit added 2 commits June 28, 2024 15:39
@obrusvit
chore(core): update translations
9e12247 
Translated copy for additional wallet backup info and some leftovers
from previous PRs.

[no changelog]
@obrusvit
chore(core): update fixtures
42d2ebc 
[no changelog]
@obrusvit obrusvit force-pushed the obrusvit/ui-t3t1-wallet-backup-info branch from eba3805 to 42d2ebc Compare June 28, 2024 13:40
@matejcik matejcik merged commit 2e10618 into main Jun 30, 2024
117 of 120 checks passed
@matejcik matejcik deleted the obrusvit/ui-t3t1-wallet-backup-info branch June 30, 2024 10:07
@bosomt
Copy link

bosomt commented Jul 1, 2024

QA OK

  • info about repeated word is visible, very nice !
  • footer x/20 is present

Info:

  • Suite version: desktop 24.6.2 (b319fb1a1e4e2fb85e398589dec064c26450bab0)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.6.2 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.0 regular (revision dd4671a)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

Assignees

@obrusvit obrusvit

Labels
T3T1 Trezor Safe 5 translations Put this label on a PR to run tests in all languages
Projects
Firmware
Archived in project
Milestone
June release
4 participants
@obrusvit @bosomt @mmilata @matejcik