chore(core): show the last passphrase character for a while #4385
Conversation
|
|
| # wait until the last digit is hidden | ||
| time.sleep(DELAY_S) | ||
| # show the entire PIN | ||
| show_passphrase(debug) |
There was a problem hiding this comment.
what's the point of showing the passphrase after every entry?
| @@ -26,6 +27,14 @@ pub enum PassphraseKeyboardMsg { | |||
| Cancelled, | |||
| } | |||
|
|
|||
| #[derive(PartialEq, Debug, Copy, Clone)] | |||
| #[cfg_attr(feature = "ui_debug", derive(ufmt::derive::uDebug))] | |||
| enum DisplayStyle { | |||
There was a problem hiding this comment.
The same enum with the same derives also in keyboard/pin.rs.
Perhaps, we can put it to some common space at least per model? Or maybe even common for all models and keyboards?
The naming could be more generic so that it captures both "chars" and "digits" and all models. Something like Hidden/Shown/LastOnly
|
|
||
|
|
||
| @pytest.mark.setup_client(passphrase=True) | ||
| def test_last_char_timeout(device_handler: "BackgroundDeviceHandler"): |
There was a problem hiding this comment.
comments talk about "digits" and "PIN" instead of "characters" and "Passphrase"
|
|
||
|
|
||
| @pytest.mark.setup_client(passphrase=True) | ||
| def test_last_char_timeout(device_handler: "BackgroundDeviceHandler"): |
|
|
||
|
|
||
| @pytest.mark.setup_client(passphrase=True) | ||
| def test_last_char_timeout(device_handler: "BackgroundDeviceHandler"): |
| self.last_char_timer.stop(); | ||
| } | ||
|
|
||
| fn render_chars<'s>(&self, area: Rect, target: &mut impl Renderer<'s>) { |
There was a problem hiding this comment.
If I look correctly, it seems that majority of the code in render_chars and render_dots is the same except the final rendering and the naming of variables (chars vs all_chars, text_baseline vs cursor).
Do you think we can somehow simplify these two functions?
This PR solves #3959 :
mercury] Introduces a feature, that shows the last typed PIN number for short period of time (1 second) before changing it to back to a bullet icontt] Introduces a feature, that shows the last typed PIN number for short period of time (1 second) before changing it to back to a*character with faded colortr] Changes the feature, where the last PIN digit is shown until non-timer (button) event to use aforementioned timeout.Changes include:
tt,mercuryTimerand 3-state enum objects to the Input struct and utilizing them to change the passphrase rendering style (stars, last character, all characters)label_keyboard_monofont...to twitching when passphrase overflowsTouchStartandTouchStopevents to show/hide entire passphrase and maximizing the touch areaapply_display_stylefunction to render the passphrase according to required rendering styletrTimerto the PassphraseEntry struct and utilizing it to change the passphrase rendering style (stars, last character, all characters)..., and keep only twitching when passphrase overflows