Consistently reject empty schema location #10044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all cases except one we don't have special handling for location being present, but an empty string. Consistently reject such value in `Database` constructor.
findepi
requested review from
losipiuk,
phd3,
alexjo2144,
kokosing and
jackye1995
losipiuk
approved these changes
Nov 24, 2021
findepi
deleted the
findepi/consistently-reject-empty-schema-location-d1239b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all cases except one we don't have special handling for location
being present, but an empty string. Consistently reject such value in
Databaseconstructor.