Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Glue database with empty location string #15438

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Support Glue database with empty location string #15438

merged 1 commit into from
Dec 16, 2022

Conversation

findepi
Copy link
Member

@findepi findepi commented Dec 16, 2022 •
edited
Loading

Follows #10044

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Dec 16, 2022
@cla-bot cla-bot bot added the cla-signed label Dec 16, 2022
@findepi
Copy link
Member Author

findepi commented Dec 16, 2022

Note: this is not testable because currently Glue does not allow creation of such databases.

(I put that note in a code comment as well)

@findepi findepi merged commit f721d57 into master Dec 16, 2022
@findepi findepi deleted the findepi/database-location-empty-string branch December 16, 2022 22:55
@github-actions github-actions bot added this to the 404 milestone Dec 16, 2022
@colebow colebow mentioned this pull request Dec 21, 2022
Merged
@findinpath findinpath mentioned this pull request Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findinpath findinpath findinpath approved these changes

@kokosing kokosing kokosing approved these changes

@ebyhr ebyhr ebyhr approved these changes

@losipiuk losipiuk Awaiting requested review from losipiuk

@alexjo2144 alexjo2144 Awaiting requested review from alexjo2144

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Milestone
405
Development

Successfully merging this pull request may close these issues.
4 participants
@findepi @ebyhr @kokosing @findinpath