Push down NULLIF in PostgreSQL connector #11532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/connector-expression-nullif
branch
2 times, most recently
from
36558c1 to
664b86f
Compare
findepi
reviewed
Mar 17, 2022
core/trino-main/src/test/java/io/trino/sql/planner/TestConnectorExpressionTranslator.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Mar 17, 2022
core/trino-spi/src/main/java/io/trino/spi/expression/StandardFunctions.java
Show resolved
Hide resolved
findepi
reviewed
Mar 17, 2022
plugin/trino-postgresql/src/main/java/io/trino/plugin/postgresql/PostgreSqlClient.java
Show resolved
Hide resolved
...n/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlConnectorTest.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/connector-expression-nullif
branch
2 times, most recently
from
963d97d to
a34af80
Compare
|
Just rebased on upstream to resolve conflicts. |
ebyhr
force-pushed
the
ebi/connector-expression-nullif
branch
from
a34af80 to
286a402
Compare
findepi
force-pushed
the
ebi/connector-expression-nullif
branch
from
286a402 to
865c68e
Compare
|
(rebased) |
findepi
approved these changes
Mar 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Push down
NULLIFin PostgreSQL connector. The 1st ~ 3rd commits will be removed after we merged #11515 & #11514.Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: