Support integer arithmetic, IS (NOT) NULL, NULLIF pushdown in MySQL connector #20378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackeryang
requested review from
findepi,
wendigo and
ebyhr
and removed request for
findepi
hackeryang
force-pushed
the
mysql_pushdown
branch
from
a8a214d to
cc1e2cb
Compare
hackeryang
changed the title
|
@hackeryang Could you confirm CI failure? |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We found that MySQL has many similar or same syntax as PostgreSQL, so some basic pushdown rules can be tried to use in MySQL and
Apache Doris(compatible with MySQL protocol) as well.Additional context and related issues
I referred to some older PRs for PostgreSQL, thanks to all relevant contributors very much:
#11510
#11514
#11532
#13136
MySQL seems doesn't support
NOT(column EXPRESSION)syntax, only support syntax such ascolumn NOT IN/BETWEEN/LIKEsyntax, so I didn't add NOT pushdown.Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: