Support Redis key pushdown in Redis connector #12219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polaris6
force-pushed
the
redis-key-pushdown
branch
from
6eb8e92 to
f80ebac
Compare
|
Hi @ebyhr, could you please help me to review this PR when you have time? Thank you very much! |
polaris6
force-pushed
the
redis-key-pushdown
branch
from
f80ebac to
2d159dc
Compare
polaris6
changed the title
ebyhr
reviewed
May 11, 2022
plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisMetadata.java
Show resolved
Hide resolved
plugin/trino-redis/src/test/java/io/trino/plugin/redis/TestMinimalFunctionality.java
Show resolved
Hide resolved
polaris6
force-pushed
the
redis-key-pushdown
branch
2 times, most recently
from
6e80401 to
460442e
Compare
|
Hi @ebyhr, could you please help me to review this PR when you have time? Thank you very much! |
|
Hi @ebyhr, could you please help review this PR when you have time? Thank you very much! |
|
Hi @ebyhr, do you have time to help review recently? This pr has been around for a long time. 🥺 Thanks! |
ebyhr
reviewed
Jun 16, 2022
plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisMetadata.java
Outdated
Show resolved
Hide resolved
...rino-redis/src/test/java/io/trino/plugin/redis/TestMinimalFunctionalityWithoutKeyPrefix.java
Outdated
Show resolved
Hide resolved
plugin/trino-redis/src/main/java/io/trino/plugin/redis/RedisRecordCursor.java
Outdated
Show resolved
Hide resolved
polaris6
force-pushed
the
redis-key-pushdown
branch
from
460442e to
aa1c713
Compare
|
@ebyhr Thanks for your advice, all updated. |
ebyhr
approved these changes
Jun 16, 2022
|
Merged, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support Redis key pushdown in Redis connector
Related issues, pull requests, and links
Fixes #12218
Documentation
(x) Sufficient documentation is included in this PR.
Release notes
(x) Release notes entries required with the following suggested text: