Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary bind in ui module #12823

Closed
wants to merge 1 commit into from

Conversation

polaris6
Copy link
Member

Description

Binding is unnecessary, so I removed it.

Documentation

(✓) No documentation is needed.

Release notes

(✓) No release notes entries required.

@polaris6 polaris6 force-pushed the remove-unnecessary-bind branch from 5ea6ef8 to 0ea0e78 Compare June 14, 2022 01:58
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is red.

@polaris6
Copy link
Member Author

@ebyhr Sorry, I misunderstood, I will close this PR.
Do you have time to help review this PR recently? This PR has been around for a long time, I really appreciate it!

@ebyhr
Copy link
Member

ebyhr commented Jun 14, 2022

@polaris6 I will review the PR when I have time. (maybe in this week)

@ebyhr ebyhr closed this Jun 14, 2022
@polaris6 polaris6 deleted the remove-unnecessary-bind branch June 14, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants