Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slate Alluxio metastore integration for removal #13559

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 9, 2022

The Alluxio integration does not seem actively maintained and seems to
have quite small user base (for example, searching for Alluxio
over Trino Slack discussions since Jan 2022 didn't return any users
using Alluxio). Yet, as any integration, it causes problems as security
scanners sometimes flag Alluxio shaded client jar as being affected by
some CVE vulnerabilities.

Mark Alluxio integration as deprecated.

The Alluxio integration does not seem actively maintained and seems to
have quite small user base (for example, searching for Alluxio
over Trino Slack discussions since Jan 2022 didn't return any users
using Alluxio). Yet, as any integration, it causes problems as security
scanners sometimes flag Alluxio shaded client jar as being affected by
some CVE vulnerabilities.

Mark Alluxio integration as deprecated.
@findepi findepi requested a review from a team August 9, 2022 09:42
@cla-bot cla-bot bot added the cla-signed label Aug 9, 2022
@martint
Copy link
Member

martint commented Aug 9, 2022

cc @apc999 @rongrong, thoughts?

@martint
Copy link
Member

martint commented Aug 9, 2022

@findepi, are those reports from scanners real security issues or false positives?

@findepi
Copy link
Member Author

findepi commented Aug 11, 2022

@electrum is probably better positioned to answer this question. I only know some users are concerned, but i don't know whether soundly so.

@rongrong
Copy link
Contributor

Is there other concerns besides the security issues? Our latest release has fixed those issues. We just need to upgrade the dependency. @beinan is working on that.

@findepi
Copy link
Member Author

findepi commented Aug 12, 2022

We just need to upgrade the dependency. @beinan is working on that.

I am aware of #13609 and that it has been merged.

@findepi findepi requested review from martint and removed request for electrum, martint, dain, losipiuk, arhimondr, sopel39, phd3 and hashhar August 22, 2022 10:05
@martint
Copy link
Member

martint commented Aug 22, 2022

There are two separate aspects of Alluxio integration:

  • Metastore
  • Caching layer

I don't think we should remove the caching layer -- there's evidence of usage in the wild (e.g, https://engineering.razorpay.com/how-trino-and-alluxio-power-analytics-at-razorpay-803d3386daaf), and Alluxio cache is still a supported product with a company behind it.

Regarding the Alluxio Metastore, I would like to hear from @rongrong, @beinan and @apc999 whether that product is still supported and whether there are any Trino users on it.

@beinan
Copy link
Member

beinan commented Aug 22, 2022

There are two separate aspects of Alluxio integration:

  • Metastore
  • Caching layer

I don't think we should remove the caching layer -- there's evidence of usage in the wild (e.g, https://engineering.razorpay.com/how-trino-and-alluxio-power-analytics-at-razorpay-803d3386daaf), and Alluxio cache is still a supported product with a company behind it.

Regarding the Alluxio Metastore, I would like to hear from @rongrong, @beinan and @apc999 whether that product is still supported and whether there are any Trino users on it.

Thank you @martint and @findepi for looking into this! I know a couple of users (e.g. a telecom operator in China) are still use the metastore from Alluixo, though this feature is not actively supported and might be rewrite in the future.

@findepi findepi changed the title Slate Alluxio integration for removal Slate Alluxio metastore integration for removal Aug 22, 2022
@findepi
Copy link
Member Author

findepi commented Aug 22, 2022

Dropping Alluxio metastore support would resolve #13270.
if Alluxio metastore is not supported by Alluxio itself, this is what we should do. am i hearing you right @beinan?

BTW this PR is about the metastore part. I updated the PR title to reflect that.

@findepi findepi merged commit 0511021 into trinodb:master Aug 25, 2022
@findepi findepi deleted the findepi/slate-alluxio-integration-for-removal-644220 branch August 25, 2022 07:10
@github-actions github-actions bot added this to the 394 milestone Aug 25, 2022
@colebow
Copy link
Member

colebow commented Aug 29, 2022

Do we want to include a release note for this?

@findepi
Copy link
Member Author

findepi commented Aug 30, 2022

@colebow good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

8 participants