Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Alluxio metastore #18195

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Remove deprecated Alluxio metastore #18195

merged 1 commit into from
Jul 14, 2023

Conversation

apc999
Copy link
Contributor

@apc999 apc999 commented Jul 9, 2023 •
edited
Loading

Description

Remove deprecated Alluxio metastore.
This is a follow up for #13559

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Jul 9, 2023
@github-actions github-actions bot added tests:hive hive Hive connector labels Jul 9, 2023
beinan
beinan approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@beinan beinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, many thanks for removing this deprecated feature!

@apc999 apc999 force-pushed the alluxioMetastore branch from 7a2144d to 002bc04 Compare July 10, 2023 04:28
@github-actions github-actions bot added hudi Hudi connector delta-lake Delta Lake connector labels Jul 10, 2023
@ebyhr ebyhr mentioned this pull request Jul 10, 2023
Merged
@apc999 apc999 force-pushed the alluxioMetastore branch from 002bc04 to aacdd0f Compare July 10, 2023 16:21
@apc999
Copy link
Contributor Author

apc999 commented Jul 11, 2023

it looks like some UT is flaky. @ksobolew can you help re-run the failing tests?

@apc999 apc999 force-pushed the alluxioMetastore branch from c2a3ee1 to 4c03bd0 Compare July 12, 2023 04:44
@apc999
Copy link
Contributor Author

apc999 commented Jul 12, 2023

@ksobolew @ebyhr can you help merge this PR? thanks!

@apc999
Copy link
Contributor Author

apc999 commented Jul 13, 2023

@ebyhr kindly request your assistance in merging this?

@apc999
Copy link
Contributor Author

apc999 commented Jul 14, 2023

@mosabua can you help take a look at this PR and merge it?

mosabua
mosabua approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that clean up. Everything passes and looks good as well. I will merge.

@mosabua mosabua merged commit 59d4859 into trinodb:master Jul 14, 2023
@apc999 apc999 deleted the alluxioMetastore branch July 14, 2023 18:08
@mosabua
Copy link
Member

mosabua commented Jul 14, 2023

fyi @colebow .. I think this does need a release notes entry

@github-actions github-actions bot added this to the 423 milestone Jul 15, 2023
@colebow colebow mentioned this pull request Aug 2, 2023
Merged
@findepi findepi mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@beinan beinan beinan approved these changes

@ksobolew ksobolew ksobolew approved these changes

@mosabua mosabua mosabua approved these changes

Assignees
No one assigned
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector hudi Hudi connector
Milestone
423
Development

Successfully merging this pull request may close these issues.
5 participants
@apc999 @mosabua @ksobolew @ebyhr @beinan