Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Alluxio metastore #18195

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Remove deprecated Alluxio metastore #18195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,10 +381,6 @@ jobs:
source plugin/trino-hive-hadoop2/conf/hive-tests-${{ matrix.config }}.sh &&
plugin/trino-hive-hadoop2/bin/run_hive_adl_tests.sh
fi
- name: Run Hive Alluxio Tests
run: |
source plugin/trino-hive-hadoop2/conf/hive-tests-${{ matrix.config }}.sh &&
plugin/trino-hive-hadoop2/bin/run_hive_alluxio_tests.sh
- name: Upload test results
uses: actions/upload-artifact@v3
# Upload all test reports only on failure, because the artifacts are large
Expand Down
23 changes: 0 additions & 23 deletions plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,29 +106,6 @@ public void testGlueMetastore()
.hasMessageContaining("Error: Configuration property 'hive.metastore.uri' was not used");
}

/**
* Verify the Alluxio metastore is not supported for Delta. Delta connector extends Hive connector and Hive connector supports Alluxio metastore.
* We explicitly disallow Alluxio metastore use with Delta.
*/
@Test
public void testAlluxioMetastore()
{
ConnectorFactory factory = getConnectorFactory();
assertThatThrownBy(() -> factory.create(
"test",
ImmutableMap.of("hive.metastore", "alluxio"),
new TestingConnectorContext()))
.hasMessageMatching("(?s)Unable to create injector, see the following errors:.*" +
"Explicit bindings are required and HiveMetastoreFactory .* is not explicitly bound.*");

assertThatThrownBy(() -> factory.create(
"test",
ImmutableMap.of("hive.metastore", "alluxio-deprecated"),
new TestingConnectorContext()))
.hasMessageMatching("(?s)Unable to create injector, see the following errors:.*" +
"Explicit bindings are required and HiveMetastoreFactory .* is not explicitly bound.*");
}

@Test
public void testNoCaching()
{
Expand Down
70 changes: 0 additions & 70 deletions plugin/trino-hive-hadoop2/bin/run_hive_alluxio_tests.sh
View file
Open in desktop

This file was deleted.

37 changes: 0 additions & 37 deletions plugin/trino-hive-hadoop2/conf/alluxio-docker.yml
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions plugin/trino-hive-hadoop2/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@
<configuration>
<excludes>
<exclude>**/TestHive.java</exclude>
<exclude>**/TestHiveAlluxioMetastore.java</exclude>
<exclude>**/TestHiveThriftMetastoreWithS3.java</exclude>
<exclude>**/TestHiveFileSystemS3.java</exclude>
<exclude>**/TestHiveFileSystemS3SelectPushdown.java</exclude>
Expand Down Expand Up @@ -347,21 +346,5 @@
</plugins>
</build>
</profile>
<profile>
<id>test-hive-hadoop2-alluxio</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<includes>
<include>**/TestHiveAlluxioMetastore.java</include>
</includes>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
Loading