-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hive connector test with HMS #14743
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5670ee3
Improve table creation test for non-existent schema
findepi 8564099
Fix variable name in test
findepi ee530a9
Use randomized schema names in testRenameMaterializedView
findepi 13a6f5e
Use createSchemaSql consistently in BaseConnectorTest
findepi 9bdf085
Add Hive connector test with HMS
findepi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
79 changes: 79 additions & 0 deletions
79
...trino-hive/src/test/java/io/trino/plugin/hive/TestHiveHmsMetastoreMinioConnectorTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.plugin.hive; | ||
|
|
||
| import io.trino.plugin.hive.containers.HiveMinioDataLake; | ||
| import io.trino.plugin.hive.s3.HiveS3Config; | ||
| import io.trino.plugin.hive.s3.S3HiveQueryRunner; | ||
| import io.trino.testing.QueryRunner; | ||
| import org.testng.SkipException; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import java.util.Map; | ||
| import java.util.OptionalInt; | ||
|
|
||
| import static io.trino.testing.sql.TestTable.randomTableSuffix; | ||
| import static java.lang.String.format; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| /** | ||
| * Similar to {@link TestHiveConnectorTest} but uses Hive metastore (HMS) and MinIO | ||
| * (S3-compatible storage) instead of file metastore and local file system. | ||
| */ | ||
| public class TestHiveHmsMetastoreMinioConnectorTest | ||
| extends BaseHiveConnectorTest | ||
| { | ||
| private final String bucketName = "test-hive-metastore-minio-" + randomTableSuffix(); | ||
|
|
||
| @Override | ||
| protected QueryRunner createQueryRunner() | ||
| throws Exception | ||
| { | ||
| HiveMinioDataLake hiveMinioDataLake = closeAfterClass(new HiveMinioDataLake(bucketName)); | ||
| hiveMinioDataLake.start(); | ||
| return S3HiveQueryRunner.builder(hiveMinioDataLake) | ||
| .setHiveProperties(Map.of( | ||
| // Reduce memory pressure when writing large files | ||
| "hive.s3.streaming.part-size", new HiveS3Config().getS3MultipartMinPartSize().toString())) | ||
| .setInitialTables(REQUIRED_TPCH_TABLES) | ||
| .build(); | ||
| } | ||
|
|
||
| @Test | ||
| public void verifyTestDataSetup() | ||
| { | ||
| assertThat(computeScalar("SELECT DISTINCT regexp_replace(\"$path\", '/[^/]*') FROM nation")) | ||
| .isEqualTo(format("s3a://%s/tpch/nation", bucketName)); | ||
| } | ||
|
|
||
| @Override | ||
| protected String createSchemaSql(String schemaName) | ||
| { | ||
| return format("CREATE SCHEMA %1$s WITH (location='s3a://%2$s/%1$s')", schemaName, bucketName); | ||
| } | ||
|
|
||
| @Override | ||
| public void testAddColumnConcurrently() | ||
| { | ||
| // TODO (https://github.com/trinodb/trino/issues/14745) adding columns may overwrite concurrent addition of columns (or some other operations) | ||
| // because adding columns currently consist of "read table, derive new table object, persist" with no locking (pessimistic nor optimistic) | ||
| throw new SkipException("The test may or may not fail, because there is a concurrency issue"); | ||
| } | ||
|
|
||
| @Override | ||
| protected OptionalInt maxTableNameLength() | ||
| { | ||
| return OptionalInt.of(128); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#14745