Add Hive connector test with HMS #14743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- assert that schema is not being implicitly created - assert also for connectors that do not support table creation
findepi
force-pushed
the
findepi/foobar-schema
branch
from
eed57f1 to
054b4e8
Compare
The test should be runnable in an environment with shared resources, so test objects need to have randomized names.
The method exists to allow running tests in environments that require a schema to have certain properties (e.g. location pointing to an S3 bucket). Apply `createSchemaSql()` to places where it was still missing.
findepi
force-pushed
the
findepi/foobar-schema
branch
from
054b4e8 to
991a7b1
Compare
findepi
commented
Oct 25, 2022
Comment on lines
+81
to
+71
| // TODO (https://github.com/trinodb/trino/issues/14745) adding columns may overwrite concurrent addition of columns (or some other operations) | ||
| // because adding columns currently consist of "read table, derive new table object, persist" with no locking (pessimistic nor optimistic) | ||
| throw new SkipException("The test may or may not fail, because there is a concurrency issue"); |
findepi
force-pushed
the
findepi/foobar-schema
branch
from
991a7b1 to
9bdf085
Compare
|
prefix extracted to #14771 :( |
|
It looks like the
generally grep logs for |
|
Is this still in progress @findepi ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #14741