Small test cleanup around schemas #14771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test should be runnable in an environment with shared resources, so test objects need to have randomized names.
findepi
added
test
no-release-notes
alexjo2144
approved these changes
Oct 26, 2022
ebyhr
approved these changes
Oct 26, 2022
The method exists to allow running tests in environments that require a schema to have certain properties (e.g. location pointing to an S3 bucket). Apply `createSchemaSql()` to places where it was still missing.
findepi
force-pushed
the
findepi/use-createschemasql-consistently-in-baseconnectortest-908c03
branch
from
865f8a1 to
4b58b91
Compare
findepi
deleted the
findepi/use-createschemasql-consistently-in-baseconnectortest-908c03
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #14743