Optimize plans involving table functions #16012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiafi
force-pushed
the
453TestTFPruningInPlans
branch
4 times, most recently
from
1c22507 to
f2de2dc
Compare
This was referenced Feb 9, 2023
kasiafi
force-pushed
the
453TestTFPruningInPlans
branch
2 times, most recently
from
acd93b7 to
d0b3b58
Compare
|
|
losipiuk
reviewed
Mar 28, 2023
.../trino-main/src/test/java/io/trino/sql/planner/assertions/TableFunctionProcessorMatcher.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Mar 28, 2023
.../main/java/io/trino/sql/planner/iterative/rule/PruneTableFunctionProcessorSourceColumns.java
Outdated
Show resolved
Hide resolved
|
|
losipiuk
approved these changes
Mar 28, 2023
Add more detailed check for TableFunctionProcessorNode.passThroughSpecifications in TableFunctionProcessorMatcher.
Add check for TableFunctionProcessorNode.requiredSymbols in TableFunctionProcessorMatcher.
Add check for TableFunctionProcessorNode.hashSymbol in TableFunctionProcessorMatcher.
Adds an optimizer rule to remove TableFunctionProcessorNode with source being an empty relation, based on the "prune when empty" property.
kasiafi
force-pushed
the
453TestTFPruningInPlans
branch
from
d0b3b58 to
0d8fe19
Compare
|
Applied comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces optimizer rules for column pruning and redundant node pruning of
TableFunctionProcessorNode.Docs not needed.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(X) Release notes are required, with the following suggested text: