Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trino 412 release notes #16881

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Add Trino 412 release notes #16881

merged 1 commit into from
Apr 5, 2023

Conversation

colebow
Copy link
Member

@colebow colebow commented Apr 4, 2023

Description

Assemble the release notes for the upcoming Trino 412 release. Fixes #16798

Release notes

(x) This is not user-visible or docs only and no release notes are required.

Verification for each pull request

Format: maintainer, PR/issue number, ✅ / ❌ rn ✅ / ❌ docs
✅ rn - release note added and verified, or assessed to be not necessary, set to ❌ rn before completion
✅ docs - need for docs assessed and merged, or assessed to be not necessary, set to ❌ docs before completion

29 Mar 2023

30 Mar 2023

31 Mar 2023

1 Apr 2023

2 Apr 2023

3 Apr 2023

4 Apr 2023

5 Apr 2023

@cla-bot cla-bot bot added the cla-signed label Apr 4, 2023
@colebow colebow marked this pull request as ready for review April 4, 2023 21:13
@colebow colebow requested review from martint and mosabua April 4, 2023 21:13
## Delta Lake connector

* Add support for arithmetic binary expressions in check constraints. ({issue}`16721`)
* Improve performance of queries that only read partition columns. ({issue}`16788`)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@findepi is this ok? Tried to reword the suggestion from the issue to avoid the double negative.


## Phoenix connector

* Improve performance of queries involving predicates with arithmetic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do we normally say for predicate pushdown

Add support for predicate pushdown for predicates with arithmetic expressions

maybe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we usually do that, but I think this is actually a superior explanation to an end user. Probably how we should've been doing it this entire time? I read the proposed release note from @hashhar and personally thought, "yeah, that's an improvement over how we've historically done this."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough .. I am happy to switch to this going forward

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this wording is what Piotr used in the very first complex pushdown release note and I liked it so copied from there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's more wordy than what we usually use but I think conveys the improvement much better

docs/src/main/sphinx/release/release-412.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-412.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-412.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-412.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-412.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-412.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-412.md Outdated Show resolved Hide resolved

## Delta Lake connector

* Add support for arithmetic binary expressions in table check constraints. ({issue}`16721`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Add support for arithmetic binary expressions in table check constraints. ({issue}`16721`)
* Add support for arithmetic binary expressions in table ``CHECK`` constraints. ({issue}`16721`)

check is a syntax element.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way is ok. In the SQL spec they are called "table check constraints"

@colebow colebow force-pushed the colebow/rn-412 branch 4 times, most recently from 045bd22 to 8719412 Compare April 5, 2023 20:01
@martint martint merged commit eb64112 into trinodb:master Apr 5, 2023
@github-actions github-actions bot added this to the 412 milestone Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Release notes for 412
4 participants