Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Iceberg connector documentation #16835

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

m57lyra
Copy link
Contributor

@m57lyra m57lyra commented Mar 31, 2023

Description

THERE ARE NO TECHNICAL CONTENT CHANGES TO EXISTING MATERIAL IN THIS PR

This PR is a follow-on to PR#15637. It reorganizes the Iceberg connector documentation to match the structure of the Hive connector documentation and, as with the Hive PR, does the following:

  • Fixes problematic verb tenses as per Google Developer Style Guide (must use present tense only).
    These included would, should, could, needs to, will be; there were not many instances.
  • Formats the few tables remaining in the old format to the list table format (and of course adds table titles).
  • Adds intro blurbs where there were none for the following section headers:
    • Metastores
    • Security
    • Procedures (used same language as the Hive blurb)
    • Table properties (used same language as the Hive blurb)
    • View management (used same language as the Hive blurb)
    • Performance (used same language as the Hive blurb)
    • File formats (used same language as the Hive blurb)

Additional context and related issues

Here is a possibly helpful screen cap showing how the Iceberg doc org lines up with the Hive doc org now:

Screenshot 2023-03-08 at 3 59 33 PM

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Mar 31, 2023
@github-actions github-actions bot added the docs label Apr 1, 2023
@electrum electrum merged commit e033f08 into trinodb:master Apr 4, 2023
@github-actions github-actions bot added this to the 412 milestone Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants