Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arithmetic binary in Delta check constraints #16721

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Support arithmetic binary in Delta check constraints #16721

merged 3 commits into from
Apr 4, 2023

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Mar 25, 2023 •
edited
Loading

Description

Support arithmetic binary in Delta check constraints

Release notes

(x) Release notes are required, with the following suggested text:

# Delta Lake
* Add support for arithmetic binary expressions in check constraints. ({issue}`16721`)

@cla-bot cla-bot bot added the cla-signed label Mar 25, 2023
@github-actions github-actions bot added delta-lake Delta Lake connector tests:hive labels Mar 25, 2023
@ebyhr ebyhr requested review from krvikash, findinpath and pajaks April 3, 2023 04:00
@ebyhr ebyhr force-pushed the ebi/delta-spark-arithmetic-binary branch from a02cb41 to 06267b1 Compare April 3, 2023 05:22
@ebyhr ebyhr requested a review from findepi April 3, 2023 05:47
@ebyhr
Copy link
Member Author

ebyhr commented Apr 3, 2023

CI hit #11131

findepi
findepi approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add parser tests showing that expression parser honors arithmetic operators priorities.

...elta-lake/src/main/java/io/trino/plugin/deltalake/expression/ArithmeticBinaryExpression.java Outdated Show resolved Hide resolved
@ebyhr ebyhr force-pushed the ebi/delta-spark-arithmetic-binary branch from 06267b1 to 20dbb02 Compare April 3, 2023 23:51
@ebyhr ebyhr self-assigned this Apr 4, 2023
@ebyhr ebyhr merged commit d944a97 into master Apr 4, 2023
@ebyhr ebyhr deleted the ebi/delta-spark-arithmetic-binary branch April 4, 2023 08:02
@ebyhr ebyhr mentioned this pull request Apr 4, 2023
Closed
@github-actions github-actions bot added this to the 412 milestone Apr 4, 2023
@colebow colebow mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krvikash krvikash krvikash approved these changes

@findepi findepi findepi approved these changes

@findinpath findinpath Awaiting requested review from findinpath

@pajaks pajaks Awaiting requested review from pajaks

Assignees

@ebyhr ebyhr

Labels
cla-signed delta-lake Delta Lake connector
Milestone
412
Development

Successfully merging this pull request may close these issues.
3 participants
@ebyhr @findepi @krvikash