Upgrade okhttp to 4.10.0 #16774
Merged
Upgrade okhttp to 4.10.0 #16774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
requested review from
hashhar and
kokosing
and removed request for
dain
|
CI hit: #16653 |
|
Thanks for this change. I have been using OkHttp 4.10.0 in production with Trino for a while. |
|
@sajjoseph does it work? :) |
Matter of fact I added HTTP/2 support in our version of Trino (I am contributing that change to airlift shortly) and OkHttp module automatically switched to HTTP/2 to communicate with Coordinator. I haven't seen any issues in our test environment. We will be promoting it to prod in a week and so we will see how older and newer clients (JDBC, CLI etc with different OkHttp versions) are behaving. |
|
That's great news @sajjoseph |
wendigo
force-pushed
the
serafin/upgrade-okhttp-v2
branch
from
1b9daff to
8c00081
Compare
|
Ping @electrum |
kokosing
approved these changes
Mar 31, 2023
client/trino-client/src/main/java/okhttp3/internal/tls/LegacyHostnameVerifier.java
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/upgrade-okhttp-v2
branch
from
8c00081 to
f9fa9f7
Compare
They were removed in OkHttp 4.x and we still rely on the legacy SSL hostname verification
wendigo
force-pushed
the
serafin/upgrade-okhttp-v2
branch
from
f9fa9f7 to
1369b84
Compare
kokosing
approved these changes
Apr 5, 2023
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes are not needed.