Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude snakeyaml from elasticsearch dependencies #16838

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Apr 1, 2023

It's a transitive dependency of elasticsearch-x-content, which we use in ElasticsearchLoader to load tpch data to Elasticsearch with json encoding. Yaml support is not needed at all.

Description

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

It's a transitive dependency of elasticsearch-x-content,
which we use in ElasticsearchLoader to load tpch data
to Elasticsearch with json encoding. Yaml support is not
needed at all.
@cla-bot cla-bot bot added the cla-signed label Apr 1, 2023
@wendigo wendigo requested a review from hashhar April 1, 2023 13:37
@hashhar hashhar added the no-release-notes This pull request does not require release notes entry label Apr 1, 2023
@hashhar hashhar merged commit 09d5317 into trinodb:master Apr 1, 2023
@github-actions github-actions bot added this to the 412 milestone Apr 1, 2023
@wendigo wendigo deleted the serafin/exclude-snakeyaml branch April 11, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

2 participants