Add use_cost_based_partitioning #16781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -276,7 +277,7 @@ else if ((!isStreamPartitionedOn(child.getProperties(), partitioningRequirement) | |||
| */ | |||
| private Optional<List<Symbol>> useParentPreferredPartitioning(AggregationNode node, Set<Symbol> parentPreferredPartitioningColumns) | |||
| { | |||
| if (isUseExactPartitioning(session)) { | |||
| if (!isUseCostBasedPartitioning(session)) { | |||
There was a problem hiding this comment.
We should still check for isUseExactPartitioning(session) right ? If use_exact_partitioning is true, I think that should supercede the new flag.
lukasz-stec
force-pushed
the
ls/073-use-cost-based-partitioning
branch
from
affafe6 to
073a13b
Compare
raunaqmorarka
approved these changes
Mar 29, 2023
Use use_cost_based_partitioning instead of use_exact_partitioning to control the cost based optimization to prefer parent partitioning. The motivation is to be able to disable the optimization if the NDV statistics are overestimated and the optimization would hurt parallelism.
lukasz-stec
force-pushed
the
ls/073-use-cost-based-partitioning
branch
from
073a13b to
a425718
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use use_cost_based_partitioning instead of use_exact_partitioning to control the cost-based optimization to prefer parent partitioning. The motivation is to be able to disable the optimization if the NDV statistics are overestimated and the optimization would hurt parallelism.
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: