Do not rely on the X-<protocol>-User HTTP header to detect a protocol #16015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Feb 7, 2023
|
In which cases is that header not provided? |
electrum
reviewed
Feb 7, 2023
| if (headerNames.contains("X-" + alternateHeaderName.get() + "-User")) { | ||
| if (headerNames.contains("X-Trino-User")) { | ||
| String headerPrefix = "x-" + alternateHeaderName.get().toLowerCase(ENGLISH); | ||
| if (headerNames.stream() |
There was a problem hiding this comment.
Nit: these would look better without wrapping
There was a problem hiding this comment.
You mean something like:
if (headerNames.stream().anyMatch(header -> header.toLowerCase(ENGLISH).startsWith(headerPrefix))) {
if (headerNames.stream().anyMatch(header -> header.toLowerCase(ENGLISH).startsWith("x-trino-"))) {
|
Now that we do user mapping for authentication, it's legitimate for a client not to send the user header, and apparently some clients do not always send it. |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Can you clarify what the next here should be @electrum ? |
electrum
reviewed
Mar 16, 2023
client/trino-client/src/main/java/io/trino/client/ProtocolHeaders.java
Outdated
Show resolved
Hide resolved
electrum
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the logic to detect a non-Trino protocol to stop relying on the X--User HTTP header.
Additional context and related issues
Trino detects alternative protocols (e.g. Presto) by looking whether the X--User HTTP header exists. In some cases however no such header is provided. So change the logic to avoid relying on that particular HTTP header and instead look for any X--* HTTP header.
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: