Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CREATE TABLE AS SELECT in Ignite type mapping #16423

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

sudip-unb
Copy link
Contributor

@sudip-unb sudip-unb commented Mar 8, 2023

Description

Fixes #16214

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot
Copy link

cla-bot bot commented Mar 8, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr ebyhr force-pushed the data-setup-ignite-connector branch from 3388a59 to 76c8036 Compare March 8, 2023 02:40
@cla-bot
Copy link

cla-bot bot commented Mar 8, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please submit CLA if you haven't sent it.

@ebyhr ebyhr changed the title Data setup ignite connector Test CREATE TABLE AS SELECT in Ignite type mapping Mar 8, 2023
@sudip-unb
Copy link
Contributor Author

@ebyhr I have submitted the CLA today.

@ebyhr
Copy link
Member

ebyhr commented Mar 8, 2023

Please take a look at CI failure.

@cla-bot
Copy link

cla-bot bot commented Mar 8, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@sudip-unb
Copy link
Contributor Author

Please take a look at CI failure.

@sudip-unb sudip-unb closed this Mar 8, 2023
@sudip-unb sudip-unb reopened this Mar 8, 2023
@cla-bot
Copy link

cla-bot bot commented Mar 8, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@sudip-unb
Copy link
Contributor Author

Working on it.

@sudip-unb sudip-unb requested a review from ebyhr March 8, 2023 15:23
@sudip-unb sudip-unb force-pushed the data-setup-ignite-connector branch from 986c6a7 to cf7ffeb Compare March 9, 2023 14:48
@cla-bot
Copy link

cla-bot bot commented Mar 9, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

1 similar comment
@cla-bot
Copy link

cla-bot bot commented Mar 9, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@sudip-unb sudip-unb force-pushed the data-setup-ignite-connector branch from 6764dd1 to 75501de Compare March 10, 2023 13:55
@cla-bot
Copy link

cla-bot bot commented Mar 10, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link

cla-bot bot commented Mar 20, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr
Copy link
Member

ebyhr commented Mar 23, 2023

@martint Could you confirm CLA from @sudip-unb ?

@sudip-unb sudip-unb force-pushed the data-setup-ignite-connector branch from e325e73 to 3a62d8f Compare April 3, 2023 19:32
@cla-bot cla-bot bot added the cla-signed label Apr 3, 2023
Additionally, check time zones in setUp method.
@ebyhr ebyhr force-pushed the data-setup-ignite-connector branch from 3a62d8f to 94845cf Compare April 3, 2023 22:57
@ebyhr ebyhr merged commit 803bf84 into trinodb:master Apr 4, 2023
@github-actions github-actions bot added this to the 412 milestone Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support Trino CTAS data setup process for Ignite connector
2 participants