Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Delta Lake connector documentation #16481

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

m57lyra
Copy link
Contributor

@m57lyra m57lyra commented Mar 9, 2023

Description

THERE ARE NO TECHNICAL CONTENT CHANGES INCLUDED IN THIS PR.

This PR is a follow-on to PR#15637. It reorganizes the Delta Lake connector documentation to match the structure of the Hive connector documentation and, as with the Hive PR, does the following:

  • Fixes problematic verb tenses as per Google Developer Style Guide (must use present tense only). These included would, should, could, needs to, will be; there were not many instances.
  • Adds intro blurbs where there were none for the following section headers:
    • Security (used same language as in Iceberg PR#16451)
    • SQL support - (copied from Iceberg PR#16451. Please check that all listed are indeed supported)
    • Procedures (used same language as the Hive blurb)
    • Schema and table management (used same language as the Hive blurb)

Additional context and related issues

Here is a possibly helpful screen cap showing how the Delta lake doc org lines up with the Hive doc org now:

Screenshot 2023-03-09 at 3 41 11 PM

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Mar 9, 2023
@m57lyra m57lyra requested a review from mosabua March 9, 2023 23:59
@github-actions github-actions bot added the docs label Mar 10, 2023
@m57lyra m57lyra force-pushed the ab/reorg-deltalake branch from 3407598 to 4d52cfc Compare March 13, 2023 17:56
@m57lyra
Copy link
Contributor Author

m57lyra commented Mar 13, 2023

Pushed verb tense fixes since review is delayed so this can move along faster.

docs/src/main/sphinx/connector/delta-lake.rst Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.rst Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/delta-lake.rst Outdated Show resolved Hide resolved
@m57lyra m57lyra force-pushed the ab/reorg-deltalake branch from 4d52cfc to 42b5833 Compare March 14, 2023 18:51
@m57lyra m57lyra force-pushed the ab/reorg-deltalake branch from 42b5833 to 6ecfa73 Compare March 31, 2023 22:35
@electrum electrum merged commit 309434f into trinodb:master Apr 4, 2023
@github-actions github-actions bot added this to the 412 milestone Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants