Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document changes in default access control #17153

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Apr 20, 2023

Description

  • Update release note for 414
  • Clarify for system access controls
  • Update affected graceful shutdown documentation

Additional context and related issues

Replaces #17142

Release notes

Release note and doc updates included. No new entry needed.

kokosing and others added 3 commits April 21, 2023 08:13
- Update release note for 414
- Clarify for system access controls
- Update affected graceful shutdown documentation

Co-authored-by: Manfred Moser <manfred@simpligility.ca>
- For system information rules of file system access control
@mosabua mosabua force-pushed the access-control branch 2 times, most recently from dcca371 to ed6acc7 Compare April 21, 2023 16:23
Copy link
Member

@colebow colebow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, but looks good overall.

docs/src/main/sphinx/admin/graceful-shutdown.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-414.md Outdated Show resolved Hide resolved
- better column width adjustment
- easier source formatting as side benefit
@mosabua
Copy link
Member Author

mosabua commented Apr 21, 2023

Should be all good now @kokosing and @colebow

@mosabua mosabua self-assigned this Apr 21, 2023
Copy link
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% comments

docs/src/main/sphinx/admin/graceful-shutdown.rst Outdated Show resolved Hide resolved
@@ -20,10 +20,10 @@

## Security

* Disallow requesting [graceful shutdown](/admin/graceful-shutdown) with the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: previous commit?

@kokosing
Copy link
Member

@mosabua Thank you!

@mosabua mosabua merged commit 6631a30 into trinodb:master Apr 24, 2023
@mosabua
Copy link
Member Author

mosabua commented Apr 24, 2023

Thanks for the technical input and confirmation @kokosing

@mosabua mosabua deleted the access-control branch April 24, 2023 15:04
@github-actions github-actions bot added this to the 415 milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants