Convert release notes source to markdown #17732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
approved these changes
Jun 2, 2023
This was referenced Jun 3, 2023
This was referenced Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using rst2myst and adjustments. Exploratory PR for the release notes only for now as prior discussed with @electrum and @martint
I am queueing up separate commits as learning exercise and squash prior to submitting for review.
Ideally I can confirm that after the conversion the produced HTML is identical. Using a folder diff tool for that during exploration.
Update:
Had to do minor manual adjustments and add some myst parser config. The produced HTML is now identical to the original apart from two places that I had to manually adjust. I fixed those and the HTML is different but looks the same so there is no negative impact. Files are release-0.69 and release-308.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: