Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert more documentation to markdown source #17759

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Jun 5, 2023

Description

  • Admin section
  • Client section
  • Installation section

Verified that the produced HTML is identical or just has wrapping and style changes that do NOT affect the output at all.

Also improved layout of some tables first to make conversion a bit easier, but left in separate commit.

Additional context and related issues

Prior PRs that migrated other docs:

#17732
#17742

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the end of this wouldn't we be left with both rst and markdown? AFAIK not everything that rst allows you to express can be expressed in markdown without dropping down to plain HTML.

In other words, it'll be helpful if you can state the goals of this change.

@mosabua
Copy link
Member Author

mosabua commented Jun 6, 2023

@hashhar .. the Myst Parser supported all features from rst and more. It will be a complete port. I am just taking it in steps since I have to find the right extensions and so on. I will also update the readme in the docs folder with info soon.

Just for reference :

https://myst-parser.readthedocs.io/en/latest/index.html

@hashhar
Copy link
Member

hashhar commented Jun 6, 2023

Ah, so we're switching parsers as well. Thanks for the context - that was the missing piece for me.

@mosabua
Copy link
Member Author

mosabua commented Jun 6, 2023

We were already using both in parallel ever since we switched the release notes to be markdown based @hashhar . Now we are just completing the move and going with it for everything. Also note that the result is not vanilla markdown .. it has a bunch of more features and syntax usage. And I am adding extensions for things as needed.

@mosabua mosabua force-pushed the mm/md-convert branch 2 times, most recently from 24f6dfc to 306552f Compare June 13, 2023 23:13
@mosabua mosabua force-pushed the mm/md-convert branch 2 times, most recently from 61685d7 to 379f4ce Compare July 20, 2023 22:02
@mosabua mosabua marked this pull request as ready for review July 20, 2023 22:27
- All files in admin folder
- All files in client folder
- All files in installation folder
@mosabua
Copy link
Member Author

mosabua commented Jul 21, 2023

Thank you @raunaqmorarka

@mosabua mosabua merged commit 524a2db into trinodb:master Jul 21, 2023
@mosabua mosabua deleted the mm/md-convert branch July 21, 2023 05:37
@github-actions github-actions bot added this to the 423 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants