Separate file metastore column serialization from internals

[findepi]

Introduce separate column class representing column serialized in file metastore.

[findepi]

Ideally the whole file metastore domain model could be seaprate.

[kokosing]

Is it possible to generate data for file based metastore and add it to the tests to make sure it can read old data? Then when changing the internals we could have backward compability tests. WDYT?

[electrum]

Why do this just for columns? If we want this, we can remove the serialization for the old class.

[electrum]

We should be able to make this a record. Also, we don’t need to use explicit names for JSON serialization in new code.

[findepi]

I would rather not refactor this class, since we have no tests for the file metastore. I don't want to change serialization state inadvertently. From my perspective, this isn't new code.

[findepi]

Why do this just for columns?

good question
just because i want to change Column-related code (#18315)

we can remove the serialization for the old class.

good point, thanks!

[findepi]

we can remove the serialization for the old class.

it appears used elsewhere (HiveInsertTableHandle["pageSinkMetadata"]->io.trino.plugin.hive.metastore.HivePageSinkMetadata["table"]->io.trino.plugin.hive.metastore.Table["dataColumns"]), will restore

[findepi]

@electrum please take another look

[findepi]

replaced with #18343