Fix HiveMetadata.streamTableColumns not to include views #18343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
findepi
requested review from
electrum,
martint,
losipiuk,
raunaqmorarka,
sopel39,
alexjo2144 and
kokosing
|
|
findepi
force-pushed
the
findepi/fix-hivemetadata-streamtablecolumns-not-to-include-views-1f2f2f
branch
from
e91798b to
9c2b5fc
Compare
findepi
commented
Jul 19, 2023
| @@ -837,6 +842,7 @@ private Stream<TableColumnsMetadata> streamTableColumns(ConnectorSession session | |||
| return Stream.empty(); | |||
| } | |||
| catch (TableNotFoundException e) { | |||
| // it is not a table (e.g. it's a view) (TODO remove exception-driven logic for this case) OR | |||
There was a problem hiding this comment.
re TODO -- FWIW this is how Iceberg does this
sopel39
reviewed
Jul 19, 2023
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/fix-hivemetadata-streamtablecolumns-not-to-include-views-1f2f2f
branch
from
9c2b5fc to
3ca488b
Compare
findepi
force-pushed
the
findepi/fix-hivemetadata-streamtablecolumns-not-to-include-views-1f2f2f
branch
from
3ca488b to
e4dc189
Compare
ebyhr
approved these changes
Jul 20, 2023
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java
Show resolved
Hide resolved
|
CI hit #11344 |
sopel39
approved these changes
Jul 20, 2023
kokosing
approved these changes
Jul 20, 2023
| @@ -614,7 +615,18 @@ private ConnectorTableMetadata doGetTableMetadata(ConnectorSession session, Sche | |||
| throw new TrinoException(UNSUPPORTED_TABLE_TYPE, format("Not a Hive table '%s'", tableName)); | |||
| } | |||
|
|
|||
| if (!translateHiveViews && isHiveOrPrestoView(table)) { | |||
| boolean isTrinoView = isPrestoView(table); | |||
There was a problem hiding this comment.
It would be nice rename the method too
There was a problem hiding this comment.
agreed, but obviously out of scope for this PR, right?
findepi
force-pushed
the
findepi/fix-hivemetadata-streamtablecolumns-not-to-include-views-1f2f2f
branch
from
e4dc189 to
3397157
Compare
The test was passing for `AbstractTestHiveLocal` because the test view was never created, so `streamTableColumns` couldn't return anything for it.
…ain path It's up to a subclass to configure connector in some way.
findepi
force-pushed
the
findepi/fix-hivemetadata-streamtablecolumns-not-to-include-views-1f2f2f
branch
from
3397157 to
5a7cd36
Compare
In the absence of explicit documentation, the use place (`io.trino.metadata.MetadataManager#listTableColumns`) defines `streamTableColumns` contract as covering tables only. This commit also supplements explicit documentation in `ConnectorMetadata`. This relates to a logic introduced in `HiveMetadata.doGetTableMetadata` in aafe479 commit. It was practical for hive views and when view translation is not enabled, but was not correct for trino views.
findepi
force-pushed
the
findepi/fix-hivemetadata-streamtablecolumns-not-to-include-views-1f2f2f
branch
from
5a7cd36 to
e4ecb16
Compare
findepi
deleted the
findepi/fix-hivemetadata-streamtablecolumns-not-to-include-views-1f2f2f
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the absence of explicit documentation, the use place
(
io.trino.metadata.MetadataManager#listTableColumns) definesstreamTableColumnscontract as covering tables only. This PR alsosupplements explicit documentation in
ConnectorMetadata.This relates to a logic introduced in
HiveMetadata.doGetTableMetadatain aafe479 commit. It was practical for
hive views and when view translation is not enabled, but was not correct
for trino views.