Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert more docs source to markdown #18432

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Jul 27, 2023

Description

Specifically connectors that are rarely changed and don't use include fragments in their documentation.

The PR also includes a narrower scope on the reserved keyword test requested by @electrum in a separate commit.

Output HTML changes are:

  • Dropped table column percentage values (which didnt work anyway, tables look better now)
  • Some wrapping in HTML source and inserted space characters instead of linefeed - no render change
  • Some anchors used to be implicit and rendered as external links, are now explicitly set and therefore rendered as internal anchors (accumulo.md and googlesheets.md)

None of the changes have a negative impact on the rendered look of the docs.

Additional context and related issues

Follow up to a bunch of other PRs
#18430
#18429
#18391
#18375

and earlier ones

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jul 27, 2023
@mosabua mosabua force-pushed the mm/more-md-convert branch from 8b6476a to 767414e Compare July 27, 2023 03:54
@github-actions github-actions bot added the docs label Jul 27, 2023
- Specifically ones that are not often changed
  and don't use included fragments
@mosabua mosabua force-pushed the mm/more-md-convert branch from 767414e to 181a804 Compare July 27, 2023 22:30
@mosabua mosabua requested a review from electrum July 27, 2023 22:33
@mosabua mosabua changed the title [WIP] Convert more docs source to markdown Convert more docs source to markdown Jul 27, 2023
@mosabua mosabua merged commit 44362bc into trinodb:master Jul 31, 2023
@mosabua mosabua deleted the mm/more-md-convert branch July 31, 2023 18:45
@github-actions github-actions bot added this to the 423 milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants