Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert more connector docs to markdown #18454

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Convert more connector docs to markdown #18454

merged 1 commit into from
Aug 3, 2023

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Jul 28, 2023 •
edited
Loading

Description

Convert more connector docs to markdown

  • All JBDC based connectors
  • Kafka and related connectors with some layout improvements
  • Blackhole connector
  • All used fragments

Changes to HTML output are:

  • some links are now explicit internal links rather than implicit links, does not affect rendering but enforces correctness of links, and actually passed build...
  • table column with header spec is gone, that improves the rendering tables actually
  • some spaces replaces linefeeds, no output render effect
  • fixed depth of some included fragments to be same level in Configuration section, old setup was wrong, see Clickhouse connector for an example
  • fixed some tables in Kafka encoder/decoder docs by migrating to list-table and plain lists

Additional context and related issues

Parallel, but without impact to #18432

Follow up to a bunch of other merged PRs:

#18430
#18429
#18391
#18375

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jul 28, 2023
@github-actions github-actions bot added the docs label Jul 28, 2023
@mosabua mosabua force-pushed the mm/connectors branch 5 times, most recently from 8f91a35 to 464a934 Compare August 1, 2023 06:36
@mosabua mosabua changed the title [WIP] Convert JDBC connector docs to markdown Convert JDBC connector docs to markdown Aug 1, 2023
@mosabua
Copy link
Member Author

mosabua commented Aug 1, 2023

All working and verified now. Will give it another complete review of all HTML files and render output tomorrow, and then this should be good to merge.

@mosabua mosabua changed the title Convert JDBC connector docs to markdown Convert more connector docs to markdown Aug 1, 2023
@mosabua mosabua force-pushed the mm/connectors branch 3 times, most recently from 92ac2ab to a55ad08 Compare August 1, 2023 21:26
@mosabua mosabua requested a review from electrum August 1, 2023 21:55
@mosabua
Convert more connector docs to markdown
c71b4d2 
- All JBDC based connectors
- Kafka and related connectors with some layout improvements
- Blackhole connector
- All used fragments
@mosabua mosabua merged commit fa23a09 into trinodb:master Aug 3, 2023
@mosabua mosabua deleted the mm/connectors branch August 3, 2023 20:05
@mosabua mosabua mentioned this pull request Aug 3, 2023
Merged
@github-actions github-actions bot added this to the 423 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum electrum approved these changes

Assignees
No one assigned
Labels
cla-signed docs
Milestone
423
Development

Successfully merging this pull request may close these issues.
2 participants
@mosabua @electrum