Update SQL support docs for Blackhole #18534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
changed the title
vlad-lyutenko
approved these changes
Aug 3, 2023
|
@vlad-lyutenko have you checked the code or tested that all view and MV statements are supported. Including ALTER ? |
mosabua
changed the title
No, for my PR (#18016) we needed only basic usages like get MV view and list all MV views |
ebyhr
reviewed
Aug 3, 2023
mosabua
commented
Aug 4, 2023
mosabua
commented
Aug 4, 2023
mosabua
commented
Aug 4, 2023
|
Updated and added some questions now @vlad-lyutenko and @ebyhr |
ebyhr
approved these changes
Aug 6, 2023
- For views - For materialized views - For tables - Also remove invalid warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding view and materialized view support.
I am not sure we can claim this as correct since ALTER VIEW and ALTER MATERIALIZED view might not be supported.. if that is the case I have to list the supported commands separately.
Additional context and related issues
Caused by missing docs in #18016
Release notes
Release notes are already tackled with implementation PR.