Post merge clean up for materialized view column comment #18628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
vlad-lyutenko
force-pushed
the
vlad-lyutenko/mv-column-comments-review
branch
from
2bfa4da to
9895b0b
Compare
|
please update 423 release notes too |
i have other fixes tbd, so will take care of this -- #18646 |
Praveen2112
reviewed
Aug 14, 2023
testing/trino-tests/src/test/java/io/trino/security/TestAccessControl.java
Show resolved
Hide resolved
plugin/trino-blackhole/src/main/java/io/trino/plugin/blackhole/BlackHoleMetadata.java
Show resolved
Hide resolved
vlad-lyutenko
force-pushed
the
vlad-lyutenko/mv-column-comments-review
branch
from
9895b0b to
f987f16
Compare
vlad-lyutenko
force-pushed
the
vlad-lyutenko/mv-column-comments-review
branch
from
f987f16 to
2329036
Compare
Praveen2112
approved these changes
Aug 21, 2023
testing/trino-tests/src/test/java/io/trino/security/TestAccessControl.java
Show resolved
Hide resolved
TestAccessControl.testCommentColumnMaterializedView
vlad-lyutenko
force-pushed
the
vlad-lyutenko/mv-column-comments-review
branch
from
2329036 to
eb9cb6d
Compare
atanasenko
approved these changes
Aug 24, 2023
marcinsbd
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clean ups for this PR #18016
Correct method order, test adjustments
refactor test access control MV column comment to use mock connector
remove blackhole MV support
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: