Improve memory usage accounting of parquet writer #18756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
requested review from
findepi,
sopel39,
lukasz-stec,
gaurav8297 and
findinpath
raunaqmorarka
force-pushed
the
pqw-dict-mem
branch
from
3040adc to
b05b97b
Compare
sopel39
approved these changes
Aug 21, 2023
wendigo
previously requested changes
Aug 22, 2023
...arquet/src/main/java/io/trino/parquet/writer/valuewriter/DictionaryFallbackValuesWriter.java
Outdated
Show resolved
Hide resolved
Code related to writing dictionaries in parquet-mr is moved to Trino to allow memory accounting related fixes in subsequent changes. Existing functionality is preserved in this commit.
Initial writer holds on to memory for dictionary
When fallback to PLAIN encoding takes place on first page, there is no need to retain DictionaryValuesWriter contents
raunaqmorarka
force-pushed
the
pqw-dict-mem
branch
from
81e2407 to
5b8598b
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve memory usage accounting of parquet writer
Additional context and related issues
Fixes #18557
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: