Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not append groupId/artifactId to the url in children #20750

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Feb 19, 2024

Before:

./mvnw help:effective-pom -pl ':trino-mysql' | grep 'url>' | head -n 1
Running `/Users/mateuszgajewski/Projects/src/github.com/trinodb/trino/mvnw`...
  <url>https://trino.io/plugin/trino-mysql</url>

After:

./mvnw help:effective-pom -pl ':trino-mysql' | grep 'url>' | head -n 1
Running `/Users/mateuszgajewski/Projects/src/github.com/trinodb/trino/mvnw`...
  <url>https://trino.io</url>

According to the project.url documentation in the Maven xsd:

<xs:documentation source="description">
            The URL to the project's homepage.
            <br><b>Default value is</b>: parent value [+ path adjustment] + (artifactId or project.directory property), or just parent value if
            project's <code>child.project.url.inherit.append.path="false"</code>
          </xs:documentation>

This invalid url (https://trino.io/core/trino-server) was added to the RPM as URL metadata field.

@wendigo wendigo force-pushed the serafin/do-not-append-group-artifact-to-url branch from ac9e585 to 2317607 Compare February 19, 2024 18:01
@wendigo
Copy link
Contributor Author

wendigo commented Feb 19, 2024

It seems that most of the uris were incorrect @martint (we inherited some from airlift/airbase)

- Do not append groupId/artifactId to the scm.url in children

- Set developerConnection to trino git uri
@wendigo wendigo force-pushed the serafin/do-not-append-group-artifact-to-url branch from 2317607 to 0e29a1c Compare February 19, 2024 18:08
@wendigo wendigo merged commit da12ce2 into master Feb 19, 2024
67 of 98 checks passed
@wendigo wendigo deleted the serafin/do-not-append-group-artifact-to-url branch February 19, 2024 18:44
@github-actions github-actions bot added this to the 440 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants