Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labeler configuration for v5 #20887

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix labeler configuration for v5 #20887

merged 1 commit into from
Feb 29, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Feb 29, 2024

https://github.com/marketplace/actions/labeler#breaking-changes-in-v5

It failed on one of my PRs:

Run actions/labeler@v5
The configuration file (path: .github/config/labeler-config.yml) was not found locally, fetching via the api
Error: Error: found unexpected type for label 'tests:hive' (should be array of config options)
Error: found unexpected type for label 'tests:hive' (should be array of config options)

@wendigo
Copy link
Contributor Author

wendigo commented Feb 29, 2024

I hope that it works. Hard to test without merging as the configuration is taken from base branch.

@wendigo wendigo merged commit 7dddd03 into master Feb 29, 2024
61 of 99 checks passed
@wendigo wendigo deleted the serafin/fix-labeler branch February 29, 2024 15:28
@github-actions github-actions bot added this to the 440 milestone Feb 29, 2024
- lib/trino-filesystem/**
- lib/trino-filesystem-*/**
- changed-files:
- any-glob-to-any-file: ['lib/trino-orc/**', 'lib/trino-parquet/**', 'lib/trino-hive-formats/**', 'plugin/trino-hive/**', 'testing/trino-product-tests/**', 'lib/trino-filesystem/**', 'lib/trino-filesystem-*/**']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this

what was wrong with the previous more readable yaml list items one-per-line syntax?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't longer supported by the v5 plugin updated by @ebyhr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the labeler yml file does not use follow yaml syntax?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've followed a syntax from readme. I guess that more yaml-ish would work too (wrapping array elements on newlines)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants