Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labeler configuration for v5 #20887

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix labeler configuration for v5 #20887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 22 additions & 18 deletions .github/config/labeler-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,44 @@
# Pull Request Labeler Github Action Configuration: https://github.com/marketplace/actions/labeler
"tests:hive":
- lib/trino-orc/**
- lib/trino-parquet/**
- lib/trino-hive-formats/**
- plugin/trino-hive/**
- testing/trino-product-tests/**
- lib/trino-filesystem/**
- lib/trino-filesystem-*/**
- changed-files:
- any-glob-to-any-file: ['lib/trino-orc/**', 'lib/trino-parquet/**', 'lib/trino-hive-formats/**', 'plugin/trino-hive/**', 'testing/trino-product-tests/**', 'lib/trino-filesystem/**', 'lib/trino-filesystem-*/**']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this

what was wrong with the previous more readable yaml list items one-per-line syntax?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't longer supported by the v5 plugin updated by @ebyhr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the labeler yml file does not use follow yaml syntax?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've followed a syntax from readme. I guess that more yaml-ish would work too (wrapping array elements on newlines)


jdbc:
- client/trino-jdbc/**
- changed-files:
- any-glob-to-any-file: 'client/trino-jdbc/**'

bigquery:
- plugin/trino-bigquery/**
- changed-files:
- any-glob-to-any-file: 'plugin/trino-bigquery/**'

delta-lake:
- plugin/trino-delta-lake/**
- changed-files:
- any-glob-to-any-file: 'plugin/trino-delta-lake/**'

hive:
- plugin/trino-hive/**
- changed-files:
- any-glob-to-any-file: 'plugin/trino-hive/**'

hudi:
- plugin/trino-hudi/**
- changed-files:
- any-glob-to-any-file: 'plugin/trino-hudi/**'

iceberg:
- plugin/trino-iceberg/**
- changed-files:
- any-glob-to-any-file: 'plugin/trino-iceberg/**'

mongodb:
- plugin/trino-mongodb/**
- changed-files:
- any-glob-to-any-file: 'plugin/trino-mongodb/**'

docs:
- docs/**
- changed-files:
- any-glob-to-any-file: 'docs/**'

release-notes:
- docs/src/main/sphinx/release/**
- docs/src/main/sphinx/release.rst
- changed-files:
- any-glob-to-any-file: ['docs/src/main/sphinx/release/**', 'docs/src/main/sphinx/release.rst']

ui:
- core/trino-main/src/main/resources/webapp/**
- changed-files:
- any-glob-to-any-file: 'core/trino-main/src/main/resources/webapp/**'
Loading