[Forward testing] Test JDK 24-ea build 24 (2024/11/14) #23501

wendigo · 2024-09-19T10:02:10Z

https://jdk.java.net/24/

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

mosabua

Looks good to go and run for testing..

Note to others ... we wont merge this ...

pom.xml

mosabua

We will have to adjust this over time .. so not ready to merge for a while .. but important for updating and monitoring progress towards 24

wendigo · 2024-10-07T05:04:19Z

Since the ASM update has landed. Now this doesn't require any code/infrastructure changes

losipiuk

mark as draft

wendigo · 2024-10-07T08:47:03Z

@losipiuk draft doesn't run CI, right?

martint · 2024-10-07T14:13:39Z

draft doesn't run CI, right?

It didn’t when the feature launched, but it does now.

wendigo · 2024-10-18T08:25:38Z

Updated to beta 20

martint · 2024-10-24T15:58:56Z

client/trino-jdbc/src/test/java/io/trino/jdbc/BaseTestJdbcResultSet.java

@@ -465,12 +465,12 @@ public void testTimeWithTimeZone()
                        Time.valueOf(
                                LocalTime.of(15, 39, 7)).getTime() /* 15:39:07 = 00:39:07 - +01:00 shift + Bahia_Banderas's shift (-8) (modulo 24h which we "un-modulo" below) */
                                - DAYS.toMillis(1) /* because we use currently 'shifted' representation, not possible to create just using LocalTime */
-                                + HOURS.toMillis(1) /* because there was offset shift on 1970-01-01 in America/Bahia_Banderas */);


Political timezones don't affect time w/ tz. These comments are no longer applicable.

martint · 2024-10-24T16:06:01Z

core/trino-main/src/test/java/io/trino/operator/scalar/TestDateTimeFunctions.java

@@ -101,7 +101,7 @@ public void testCurrentDateTimezone()
                millis += timeIncrement) {
            Instant instant = Instant.ofEpochMilli(millis);
            assertCurrentDateAtInstant(kievTimeZoneKey, instant);
-            assertCurrentDateAtInstant(bahiaBanderasTimeZoneKey, instant);
+            assertCurrentDateAtInstant(bajaSurTimeZoneKey, instant);


No sure what this test buys us. I would just drop it.

martint · 2024-10-24T16:06:28Z

core/trino-main/src/test/java/io/trino/operator/scalar/TestDateTimeFunctions.java

@@ -397,7 +397,7 @@ public void testLastDayOfMonth()
        assertThat(assertions.function("last_day_of_month", "TIMESTAMP '2001-08-22 03:04:05.321 +07:09'"))
                .matches("DATE '2001-08-31'");

-        ImmutableList.of("+05:45", "+00:00", "-05:45", "Asia/Tokyo", "Europe/London", "America/Los_Angeles", "America/Bahia_Banderas").forEach(timeZone -> {
+        ImmutableList.of("+05:45", "+00:00", "-05:45", "Asia/Tokyo", "Europe/London", "America/Los_Angeles", "Mexico/BajaSur").forEach(timeZone -> {


ksobolew · 2024-11-20T11:07:39Z

...lient/src/main/java/io/trino/client/auth/kerberos/DelegatedUnconstrainedContextProvider.java

+    private static Subject current()
+    {
+        try {
+            Method current = Subject.class.getDeclaredMethod("current");
+            return (Subject) current.invoke(null);
+        }
+        catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException ignored) {
+            // Fallback to pre-Java 17 method
+            return Subject.getSubject(AccessController.getContext());
+        }
+    }


Maybe it's time to bump the Java version from the ancient 8 to something less ancient in trino-client?

(Moved to #24197 (comment))

cla-bot bot added the cla-signed label Sep 19, 2024

wendigo mentioned this pull request Sep 19, 2024

Use and require Java 24 #23498

Open

12 tasks

wendigo force-pushed the serafin/jdk24-ea branch 6 times, most recently from 9f6711d to 5fc99f9 Compare September 19, 2024 12:01

wendigo changed the title ~~[WIP] Test JDK 24-ea~~ [Forward testing] Test JDK 24-ea Sep 19, 2024

wendigo force-pushed the serafin/jdk24-ea branch from 5fc99f9 to 9d011de Compare September 19, 2024 15:47

wendigo requested a review from mosabua September 20, 2024 06:43

mosabua approved these changes Sep 20, 2024

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

wendigo force-pushed the serafin/jdk24-ea branch 2 times, most recently from a834a55 to b97f836 Compare September 23, 2024 13:47

wendigo changed the title ~~[Forward testing] Test JDK 24-ea~~ [Forward testing] Test JDK 24-ea build 16 (2024/9/19) Sep 23, 2024

wendigo changed the title ~~[Forward testing] Test JDK 24-ea build 16 (2024/9/19)~~ [DONOTMERGE] [Forward testing] Test JDK 24-ea build 16 (2024/9/19) Sep 23, 2024

mosabua requested changes Sep 24, 2024

View reviewed changes

wendigo force-pushed the serafin/jdk24-ea branch 2 times, most recently from 6492488 to 12a1333 Compare September 30, 2024 19:29

wendigo changed the title ~~[DONOTMERGE] [Forward testing] Test JDK 24-ea build 16 (2024/9/19)~~ [DONOTMERGE] [Forward testing] Test JDK 24-ea build 17 (2024/9/19) Oct 1, 2024

wendigo force-pushed the serafin/jdk24-ea branch from 12a1333 to 3dad9e2 Compare October 7, 2024 05:03

wendigo changed the title ~~[DONOTMERGE] [Forward testing] Test JDK 24-ea build 17 (2024/9/19)~~ [DONOTMERGE] [Forward testing] Test JDK 24-ea build 18 (2024/10/04) Oct 7, 2024

losipiuk approved these changes Oct 7, 2024

View reviewed changes

losipiuk marked this pull request as draft October 7, 2024 08:46

wendigo force-pushed the serafin/jdk24-ea branch from 3dad9e2 to d2384d3 Compare October 11, 2024 18:02

wendigo changed the title ~~[DONOTMERGE] [Forward testing] Test JDK 24-ea build 18 (2024/10/04)~~ [Forward testing] Test JDK 24-ea build 19 (2024/10/10) Oct 11, 2024

wendigo force-pushed the serafin/jdk24-ea branch from d2384d3 to 375add6 Compare October 11, 2024 18:50

wendigo force-pushed the serafin/jdk24-ea branch from 375add6 to 7fc457c Compare October 18, 2024 08:24

wendigo force-pushed the serafin/jdk24-ea branch 3 times, most recently from 35ab167 to a23c7d9 Compare October 22, 2024 12:33

github-actions bot added jdbc Relates to Trino JDBC driver iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector labels Oct 22, 2024

wendigo force-pushed the serafin/jdk24-ea branch 2 times, most recently from f214df6 to 8fa6213 Compare October 22, 2024 13:01

martint reviewed Oct 24, 2024

View reviewed changes

wendigo force-pushed the serafin/jdk24-ea branch 2 times, most recently from 2a9d995 to 5d973f1 Compare November 5, 2024 11:51

wendigo force-pushed the serafin/jdk24-ea branch 2 times, most recently from f1b284d to 5b72102 Compare November 19, 2024 13:02

wendigo changed the title ~~[Forward testing] Test JDK 24-ea build 19 (2024/10/10)~~ [Forward testing] Test JDK 24-ea build 22(2024/11/14) Nov 19, 2024

Test JDK 24-ea beta 24

5f1e3dd

wendigo force-pushed the serafin/jdk24-ea branch from 5b72102 to 5f1e3dd Compare November 19, 2024 15:42

Remove security.manager allowance

e459637

github-actions bot added the docs label Nov 19, 2024

wendigo force-pushed the serafin/jdk24-ea branch from 6600d1c to d9c43b2 Compare November 20, 2024 10:19

ksobolew reviewed Nov 20, 2024

View reviewed changes

wendigo added 3 commits November 20, 2024 13:32

Timezone changes

74b5c2a

Use snapshot for hive-jdbc driver

d1d776a

Support post JDK 17 Subject.current

21f07ad

wendigo force-pushed the serafin/jdk24-ea branch from 350bf60 to 21f07ad Compare November 20, 2024 12:33

fixup! Timezone changes

35a3c7f

wendigo force-pushed the serafin/jdk24-ea branch from 055e705 to 35a3c7f Compare November 20, 2024 16:32

wendigo changed the title ~~[Forward testing] Test JDK 24-ea build 22(2024/11/14)~~ [Forward testing] Test JDK 24-ea build 24 (2024/11/14) Nov 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Forward testing] Test JDK 24-ea build 24 (2024/11/14) #23501

[Forward testing] Test JDK 24-ea build 24 (2024/11/14) #23501

wendigo commented Sep 19, 2024 •

edited

Loading

mosabua left a comment

mosabua left a comment

wendigo commented Oct 7, 2024

losipiuk left a comment

wendigo commented Oct 7, 2024

martint commented Oct 7, 2024

wendigo commented Oct 18, 2024

martint Oct 24, 2024

martint Oct 24, 2024

martint Oct 24, 2024

ksobolew Nov 20, 2024

ksobolew Nov 20, 2024

[Forward testing] Test JDK 24-ea build 24 (2024/11/14) #23501

Are you sure you want to change the base?

[Forward testing] Test JDK 24-ea build 24 (2024/11/14) #23501

Conversation

wendigo commented Sep 19, 2024 • edited Loading

Description

Additional context and related issues

Release notes

mosabua left a comment

Choose a reason for hiding this comment

mosabua left a comment

Choose a reason for hiding this comment

wendigo commented Oct 7, 2024

losipiuk left a comment

Choose a reason for hiding this comment

wendigo commented Oct 7, 2024

martint commented Oct 7, 2024

wendigo commented Oct 18, 2024

martint Oct 24, 2024

Choose a reason for hiding this comment

martint Oct 24, 2024

Choose a reason for hiding this comment

martint Oct 24, 2024

Choose a reason for hiding this comment

ksobolew Nov 20, 2024

Choose a reason for hiding this comment

ksobolew Nov 20, 2024

Choose a reason for hiding this comment

wendigo commented Sep 19, 2024 •

edited

Loading