Support views in iceberg connector #2703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test in |
electrum
reviewed
Feb 1, 2020
presto-iceberg/src/main/java/io/prestosql/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
|
@alexey-fin Please see why few checks fail. |
|
@alexey-fin Any update on the PR? It will be good to enable view support in the iceberg connector. |
|
Sorry, @vrozov, will get back to it as soon as i can |
electrum
requested changes
Feb 26, 2020
| @@ -1710,24 +1685,11 @@ public void dropView(ConnectorSession session, SchemaTableName viewName) | |||
| @Override | |||
| public Optional<ConnectorViewDefinition> getView(ConnectorSession session, SchemaTableName viewName) | |||
| { | |||
| return metastore.getTable(new HiveIdentity(session), viewName.getSchemaName(), viewName.getTableName()) | |||
| HiveIdentity identity = new HiveIdentity(session); | |||
There was a problem hiding this comment.
This can stay inlined in the getTable call
| .setParameters(properties) | ||
| .setViewOriginalText(Optional.of(encodeViewData(definition))) | ||
| .setViewExpandedText(Optional.of("/* Presto View */")); | ||
| Table table = HiveUtil.buildViewTable(definition, viewName, owner, session.getQueryId(), prestoVersion); |
| .build(); | ||
| String owner = session.getUser(); | ||
|
|
||
| Table table = HiveUtil.buildViewTable(definition, viewName, owner, session.getQueryId(), prestoVersion); |
|
Note that we still need tests in |
|
@alexey-fin Are you still interested in this? Would you like someone else to take this over? |
|
Superseded by #8540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CREATE/GET/DROP VIEW
I copied functions from HiveMetadata, adjusting for not having SemiTransactionalHiveMetastore