Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Trino views in Iceberg connector #8540

Closed
wants to merge 8 commits into from
Closed

Add support for Trino views in Iceberg connector #8540

wants to merge 8 commits into from

Conversation

losipiuk
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jul 13, 2021
@losipiuk losipiuk requested review from phd3, findepi and alexjo2144 July 13, 2021 15:19
@mosabua
Copy link
Member

mosabua commented Jul 13, 2021

Trino views ;-)

findepi
findepi approved these changes Jul 14, 2021
View reviewed changes
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Outdated Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Outdated Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Outdated Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Outdated Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java Outdated Show resolved Hide resolved
@findepi
Copy link
Member

findepi commented Jul 14, 2021

Please add a product test (to exercise Iceberg views with HMS; this could cover Hive interoperability -- should be tested regardless of what we the interop to be (support / fail ignore)) and we should also think how we will test Iceberg views with Glue.

@losipiuk losipiuk changed the title Add support for Presto views in Iceberg connector Add support for Trino views in Iceberg connector Jul 14, 2021
@losipiuk
Copy link
Member Author

@findepi AC

@losipiuk losipiuk force-pushed the lo/iceberg-views branch 2 times, most recently from 03a7201 to a82a230 Compare July 16, 2021 08:16
findepi
findepi approved these changes Jul 16, 2021
View reviewed changes
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMetadataListing.java Show resolved Hide resolved
...oduct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveMetadataListing.java Outdated Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java Show resolved Hide resolved
...ct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveViewsCompatibility.java Outdated Show resolved Hide resolved
...ct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveViewsCompatibility.java
onTrino().executeQuery("CREATE VIEW iceberg.default.iceberg_view_qualified_iceberg AS SELECT * FROM iceberg.default.iceberg_table");
onTrino().executeQuery("CREATE VIEW iceberg.default.iceberg_view_unqualified_iceberg AS SELECT * FROM iceberg_table");

// both hive and iceberg catalogs should list all the views.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before doing that, consider USE memory.default or something

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYM?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you use USE above to the state isn't "clean". let's USE something else to not be biased towards iceberg catalog.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

...ct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveViewsCompatibility.java Outdated Show resolved Hide resolved
losipiuk
losipiuk commented Jul 16, 2021
View reviewed changes
Copy link
Member Author

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@losipiuk losipiuk force-pushed the lo/iceberg-views branch 2 times, most recently from 3d011ab to 0939bbb Compare July 16, 2021 13:00
phd3
phd3 reviewed Jul 16, 2021
View reviewed changes
Copy link
Member

@phd3 phd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Outdated Show resolved Hide resolved
...ct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveViewsCompatibility.java Show resolved Hide resolved
...ct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveViewsCompatibility.java Outdated Show resolved Hide resolved
...ct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveViewsCompatibility.java Outdated Show resolved Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java Show resolved Hide resolved
@mosabua
Copy link
Member

mosabua commented Jul 16, 2021 •
edited
Loading

As discussed with @electrum and @dain we should add this to the documentation to support views management. As such .. all statements in there should be supported.

See
https://github.com/trinodb/trino/blob/master/docs/src/main/sphinx/language/sql-support.rst#views-management
for list of statements

@findepi
Copy link
Member

findepi commented Jul 17, 2021

@phd3 thanks for your review!
I answered to the comments & added some small fixups.

phd3
phd3 approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@phd3 phd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment, other wise looks good.

@losipiuk
Copy link
Member Author

Thanks @phd3 for review and @findepi for addressing comments :)

@findepi
Copy link
Member

findepi commented Jul 19, 2021

Merged as 7651769, thanks!

@findepi findepi closed this Jul 19, 2021
This was referenced Jul 19, 2021
Closed
Closed
Merged
@mosabua mosabua mentioned this pull request Jul 20, 2021
Merged
@mosabua
Copy link
Member

mosabua commented Jul 20, 2021

Follow up PR #8621

@findepi findepi added this to the 360 milestone Sep 8, 2021
@ebyhr ebyhr mentioned this pull request Mar 24, 2022
Closed
@raunaqmorarka raunaqmorarka mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

@phd3 phd3 phd3 approved these changes

@alexjo2144 alexjo2144 Awaiting requested review from alexjo2144

Assignees
No one assigned
Labels
cla-signed
Milestone
360
Development

Successfully merging this pull request may close these issues.
4 participants
@losipiuk @mosabua @findepi @phd3