Mark view creator in metastore #8586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/distinguish-hive-iceberg
branch
from
b1a3b3f to
784a31b
Compare
|
rebased after #8540 is merged |
|
CI #8602 |
phd3
approved these changes
Jul 19, 2021
| @@ -1056,6 +1058,7 @@ public void createMaterializedView(ConnectorSession session, SchemaTableName vie | |||
| .put(PRESTO_QUERY_ID_NAME, session.getQueryId()) | |||
| .put(STORAGE_TABLE, storageTableName) | |||
| .put(PRESTO_VIEW_FLAG, "true") | |||
| .put(TRINO_CREATED_BY, "Trino Iceberg connector") | |||
There was a problem hiding this comment.
optional: define and use a constant to avoid unintentional divergence
To be able to track down what created given view. I.e. to distinguish between things created by Hive connector and Iceberg connector, if they share metastore.
findepi
force-pushed
the
findepi/distinguish-hive-iceberg
branch
from
f876eb5 to
3c50304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.