Fix SHOW STATS for boolean #9711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/fix-show-stats-for-boolean-da9a9b
branch
from
428a3f0 to
ab12753
Compare
findepi
force-pushed
the
findepi/fix-show-stats-for-boolean-da9a9b
branch
from
c831176 to
ada4a62
Compare
losipiuk
reviewed
Oct 20, 2021
Comment on lines
+216
to
+221
| if (value == 0) { | ||
| representation = "false"; | ||
| } | ||
| else if (value == 1) { | ||
| representation = "true"; | ||
| } |
There was a problem hiding this comment.
Maybe allow some "epsilon" when comparing here?
There was a problem hiding this comment.
i couldn't figure case where this would be needed, ie some realistic situation where we have eg 0.99.
would prefer to leave it for now, not have 'smarts' that are not needed
kokosing
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9710
Extracted from #9712