Fix NPE in Iceberg stats reader #9719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Oct 20, 2021
Comment on lines
+72
to
+77
| this.minValues = new HashMap<>(); | ||
| this.maxValues = new HashMap<>(); | ||
| this.nullCounts = new HashMap<>(); | ||
| this.columnSizes = new HashMap<>(); | ||
| this.corruptedStats = new HashSet<>(); | ||
| this.hasValidColumnMetrics = false; |
There was a problem hiding this comment.
do those need to be mutable objects? Can you use emptyMap/emptySet (or ImmutableMap/Set.of) instead?
There was a problem hiding this comment.
see the else { branch here which creates mutable objects and then update... methods which modifies them.
IMO there is a hope we can simplify this code ... #9716
findepi
force-pushed
the
findepi/iceberg-more-show-stats
branch
from
b8c30ea to
1132cce
Compare
findepi
force-pushed
the
findepi/iceberg-more-show-stats
branch
from
1132cce to
1488b34
Compare
alexjo2144
reviewed
Oct 25, 2021
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/TableStatisticsMaker.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Oct 25, 2021
findepi
force-pushed
the
findepi/iceberg-more-show-stats
branch
from
1488b34 to
8bf1185
Compare
|
(just rebased) |
Fixes ``` java.lang.NullPointerException at io.trino.plugin.iceberg.TableStatisticsMaker.updatePartitionedStats(TableStatisticsMaker.java:316) at io.trino.plugin.iceberg.TableStatisticsMaker.updateSummaryMin(TableStatisticsMaker.java:298) at io.trino.plugin.iceberg.TableStatisticsMaker.makeTableStatistics(TableStatisticsMaker.java:155) at io.trino.plugin.iceberg.TableStatisticsMaker.getTableStatistics(TableStatisticsMaker.java:73) at io.trino.plugin.iceberg.IcebergMetadata.getTableStatistics(IcebergMetadata.java:693) ``` However, further fixes in that code area are due.
findepi
force-pushed
the
findepi/iceberg-more-show-stats
branch
from
8bf1185 to
9466aa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9714 but follow up #9716 is due
Currently based on #9711, #9712, #9706, #9705, #9757