Fix "Bombing Raids should be dealt with first!" error. #11848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could happen if a unit is sent to bomb somewhere but then gets moved again, resulting in an empty battle (which gets skipped during the bombing battle phase). This removes the logic for considering empty for the purposes of this error. Also removes code to cancel such battle right before throwing the error, since the expectation is that we shouldn't be hitting this codepath, so no need to try to "handle" the situation. Also, some related cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could happen if a unit is sent to bomb somewhere but then gets moved again, resulting in an empty battle (which gets skipped during the bombing battle phase). This removes the logic for considering empty for the purposes of this error. Also removes code to cancel such battle right before throwing the error, since the expectation is that we shouldn't be hitting this codepath, so no need to try to "handle" the situation.
Fixes: #11846
Change Summary & Additional Notes
Release Note